Skip to content

Add example for error handling in ExecutionContext #2777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 3, 2023

Conversation

som-snytt
Copy link
Contributor

It was helpful to me to work out this example, as a refresher. Therefore, it may be helpful to beginners, in case there are still beginners out there using Future for the first time.

The existing words are correct, but might require a few hours of experimentation (or debugging) to comprehend.

@som-snytt som-snytt force-pushed the issue/12779-future-failures branch from 9f00345 to 30466c2 Compare April 26, 2023 18:26
@som-snytt
Copy link
Contributor Author

The failure is unrelated

For the Links > Internal check, the following failures were found:

* At ./_site/sips/quote-pattern-type-variable-syntax.html:604:

  internally linking to Explicit-type-variables, which does not exist

Tried rebasing.

@som-snytt
Copy link
Contributor Author

som-snytt commented Apr 26, 2023

The example should be specialized for Scala 3. (In particular, nonlocal return.)

@julienrf
Copy link
Contributor

Hey, indeed the failure was unrelated to your PR, I fixed it on main.

@som-snytt som-snytt force-pushed the issue/12779-future-failures branch from 30466c2 to c9b5a90 Compare April 27, 2023 04:34
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @som-snytt for adding this clarification! I have left a few comments.

@julienrf
Copy link
Contributor

julienrf commented May 1, 2023

Hey @som-snytt, I took the liberty to make some changes to your initial PR, I hope this is fine with you. What do you think of the result?

Here is the rendering of the Scala 3 version:

image

Copy link
Contributor Author

@som-snytt som-snytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I see indentation doesn't matter after all. (I wasn't sure.) I don't have approval privilege on this repo, but I approve this message.

@julienrf
Copy link
Contributor

julienrf commented May 2, 2023

Thank you for the review! I’ve updated the imports according to your feedback. What do you think of the result?

@julienrf julienrf merged commit a2f2239 into scala:main May 3, 2023
@som-snytt som-snytt deleted the issue/12779-future-failures branch May 3, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants