-
Notifications
You must be signed in to change notification settings - Fork 1k
Add example for error handling in ExecutionContext #2777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9f00345
to
30466c2
Compare
The failure is unrelated
Tried rebasing. |
The example should be specialized for Scala 3. (In particular, nonlocal return.) |
Hey, indeed the failure was unrelated to your PR, I fixed it on |
30466c2
to
c9b5a90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @som-snytt for adding this clarification! I have left a few comments.
Also add the Scala 3 version of the code example
Hey @som-snytt, I took the liberty to make some changes to your initial PR, I hope this is fine with you. What do you think of the result? Here is the rendering of the Scala 3 version: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I see indentation doesn't matter after all. (I wasn't sure.) I don't have approval privilege on this repo, but I approve this message.
Thank you for the review! I’ve updated the imports according to your feedback. What do you think of the result? |
It was helpful to me to work out this example, as a refresher. Therefore, it may be helpful to beginners, in case there are still beginners out there using
Future
for the first time.The existing words are correct, but might require a few hours of experimentation (or debugging) to comprehend.