-
Notifications
You must be signed in to change notification settings - Fork 1k
Translated the migration guide page into Japanese. #2235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
コントリビューションありがとうございます。 docs.scala-lang の翻訳だとガイドと概要系はだ・である語調なので、そちらに統一した方がいいと思いますが、どうでしょうか。 |
ひとまずビルドは通っていないものの、2ファイルについてコメント反映させていただきました。 |
@eed3si9n |
@eed3si9n |
where does this PR stand? |
@SethTisue I haven't taken a look at it in a while, but last I checked there it needed a lot of editing and rework (I made 76 comments in 7 pages). Anyone who "reviews" this PR would effectively have to comprehend the English original and redo some of the translation. Instead of making individual comments, I was thinking it might be better to use GitHub's review feature to stock up all comments, but it hasn't been my priority to go over the rest of 20 or so pages. If other reviewers (@scala/docs-ja or others) want to continue reviewing, or give ok to merge as-is I won't stand in the way, but in my opinion it's not yet at the standard of other translation works that we've typically maintained. |
The migration guide page was great, so I quickly translated it into Japanese.
I was careful not to change the overall meaning of the translation.
state of review