Add the Scala 3 Migration Guide #1991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks @adpi2 for this enormous effort! Is the PR ready for review and should I review it? |
|
@b-studios Yes this PR is ready, and I would be grateful if you do the final review! |
b-studios
suggested changes
May 4, 2021
There was a problem hiding this comment.
Everything looks great. Though, I have mostly reviewed for integration into the page and did not focus too much on the actual content.
There are two things:
- It seems you deleted
_overviews/scala3-macros/index.md - Maybe you also want to update the
scala3/guides.mdfile?
| <script src="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/9.9.0/highlight.min.js" type="text/javascript"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/9.9.0/languages/scala.min.js" type="text/javascript"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/9.9.0/languages/java.min.js" type="text/javascript"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/10.7.2/highlight.min.js" type="text/javascript"></script> |
There was a problem hiding this comment.
It is difficult for me to verify that this doesn't break anything anywhere else.
There was a problem hiding this comment.
I need this upgrade to get support of text area.
instead of
I hope it does not break anything, but if it does we can revert it and find another solution.
adpi2
force-pushed
the
migration-guide
branch
2 times, most recently
from
e6287e4 to
5df0083
Compare
b-studios
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the content from https://scalacenter.github.io/scala-3-migration-guide to docs.scala-lang.org:
Except:
Also contains a fix of the duplicated
index.mdfile in the macro-tutorial.