Skip to content

Late Review of "A Taste of Scala" in the Scala 3 doc. #1865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2021

Conversation

adpi2
Copy link
Member

@adpi2 adpi2 commented Dec 22, 2020

My modest contribution to the "A Taste of Scala" in the Scala 3 doc.

Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Adrien!

@adpi2 adpi2 force-pushed the scala3-taste branch 4 times, most recently from c4d72db to 246e540 Compare December 23, 2020 12:56
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my take on the matter, it’s fine if you disagree 😄

Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are getting somewhere 😉

@julienrf
Copy link
Contributor

This is good to go, thanks for your patience Adrien 😄

There is a conflict that needs to be resolved.

@b-studios b-studios added the scala-3 scala 3 documentation label Jan 4, 2021
@b-studios b-studios merged commit 1e29e6b into scala:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scala-3 scala 3 documentation
3 participants