Skip to content

Batch of updates for SIPs #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 3, 2019
Prev Previous commit
Next Next commit
Move “dormant” SIPs in a dedicated section
  • Loading branch information
julienrf committed Dec 2, 2019
commit 43bbda67e552d3a1426119c40c2e3d5a69c60952
2 changes: 2 additions & 0 deletions _sass/layout/sips.scss
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@

.pending,
.completed,
.dormant,
.rejected {
.date {
display: block;
Expand Down Expand Up @@ -169,6 +170,7 @@
@include justify-content(space-between);

.completed,
.dormant,
.rejected {
display: flex;
flex-direction: column;
Expand Down
16 changes: 15 additions & 1 deletion _sips/all.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ redirect_from: "/sips/pending/index.html"
<ul>
{% assign sips = site.sips | sort: date | reverse %}
{% for sip in sips %}
{% if sip.vote-status == "under-review" or sip.vote-status == "pending" or sip.vote-status == "dormant" or sip.vote-status == "under-revision" %}
{% if sip.vote-status == "under-review" or sip.vote-status == "pending" or sip.vote-status == "under-revision" %}
<li>
<strong><a href="{{ sip.url }}">{{ sip.title }}</a></strong>
<div class="date">{{ sip.date | date: '%B %Y' }}</div>
Expand All @@ -39,6 +39,20 @@ redirect_from: "/sips/pending/index.html"
{% endfor %}
</ul>
</div>
<div class="dormant">
<h2>Dormant</h2>
<ul>
{% for sip in sips %}
{% if sip.vote-status == "dormant" %}
<li>
<strong><a href="{{ sip.url }}">{{ sip.title }}</a></strong>
<div class="date">{{ sip.date | date: '%B %Y' }}</div>
<div class="tag" style="background-color: {{ site.data.sip-data[sip.vote-status].color }}">{{ site.data.sip-data[sip.vote-status].text }}</div>
</li>
{% endif %}
{% endfor %}
</ul>
</div>
<div class="rejected">
<h2>Rejected</h2>
<ul>
Expand Down