Skip to content

Make index page of "Overviews" translatable again and add its Japanese translation #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2019

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Jul 30, 2019

Closes #938
cc: @eed3si9n @dongxuwang

The index page of "Overviews" had been redesigned several years ago, without consideration for translation.

This PR makes the redesigned overviews.html template works for other languages.

All actions contributors need to do are

  1. Add their lang code in languages property of /_overviews/index.md
  2. Add theire _{lang/overviews/index.md based on _overviews/index.md.
    • Ensure layout: overviews. overviews uses a redesigned theme.
    • Drop languages property and add language: {lang} instead.
  3. Add /_data/overview-{lang}.yml based on /_data/overview.yml
    • Just keep urls in the file as same as English version. overviews.html will generate automatically a link: if the page has {lang} translated version, the generated link will be a translated version. Otherwise English version.

See how it works in Japanese.
japanese-translation-of-overviews-index

@eed3si9n
Copy link
Member

In the screen capture, I see the chapter names of Collection overview in English, like Arrays. Is that correct?

@exoego
Copy link
Contributor Author

exoego commented Jul 30, 2019

In the screen capture, I see the chapter names of Collection overview in English, like Arrays. Is that correct?

Forgotten to translte.
Fixed in b00eb9f

@eed3si9n eed3si9n merged commit 2ed1d6b into scala:master Jul 30, 2019
@exoego exoego deleted the ja/overviews branch July 30, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants