Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

docs: Add some more Binary Config details #2456

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: Add some more Binary Config details #2456

wants to merge 1 commit into from

Conversation

@nschonni
Copy link
Contributor

@nschonni nschonni commented Jul 20, 2018

@xzyfer I don't think this is actually correct, but maybe we can add another "Description" column to help too
@nschonni nschonni requested a review from xzyfer July 20, 2018 02:43
xzyfer
xzyfer reviewed Jul 20, 2018
View reviewed changes
README.md
SASS_BINARY_DIR | sass_binary_dir | --sass-binary-dir | path
Variable name | .npmrc parameter | Process argument | Value | Example
-----------------|------------------|--------------------|-------|----------------------------
SASS_BINARY_NAME | sass_binary_name | --sass-binary-name | path | win32-x64-57
Copy link
Contributor

@xzyfer xzyfer Jul 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

binary name includes the .node extension

node-sass/test/runtime.js

Line 29 in 3331891

assert.equal(sass.getBinaryName(), 'aaa_binding.node');

@xzyfer
Copy link
Contributor

xzyfer commented Jul 20, 2018

Thanks for doing this
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Community - Documentation Module - Binding

2 participants

@nschonni @xzyfer