This repository was archived by the owner on Jul 24, 2024. It is now read-only.
chore: Remove memory-tests #2442
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Let's keep these. I'm using them now for the N-API work to prevent
regressions.
…On Mon., 9 Jul. 2018, 4:37 pm Nick Schonning, ***@***.***> wrote:
Just noticed these when I trying opening up the ESLint globs. These look
specific to the work down in 4.7 memory performance stuff. Since we don't
actually run this as part of any part of the build process I think they can
be dropped.
------------------------------
You can view, comment on, or merge this pull request online at:
#2442
Commit Summary
- chore: Remove memory-tests
File Changes
- *D* memory-tests/_measure.js
<https://github.com/sass/node-sass/pull/2442/files#diff-0> (12)
- *D* memory-tests/boolean.js
<https://github.com/sass/node-sass/pull/2442/files#diff-1> (6)
- *D* memory-tests/function-bridge.js
<https://github.com/sass/node-sass/pull/2442/files#diff-2> (15)
- *D* memory-tests/map.js
<https://github.com/sass/node-sass/pull/2442/files#diff-3> (17)
- *D* memory-tests/string.js
<https://github.com/sass/node-sass/pull/2442/files#diff-4> (6)
Patch Links:
- https://github.com/sass/node-sass/pull/2442.patch
- https://github.com/sass/node-sass/pull/2442.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2442>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAjZWFlNMLP8lg99nM80zRz-2UD6Cnyoks5uEvoOgaJpZM4VHJ38>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed these when I trying opening up the ESLint globs. These look specific to the work down in 4.7 memory performance stuff. Since we don't actually run this as part of any part of the build process I think they can be dropped.