Add partial support for Media Queries Level 4 #1749
Conversation
| "If conditions is longer than one element, conjunction may not be " | ||
| "null."); |
There was a problem hiding this comment.
Nit: would adding single-quotes around conditions and conjunction make it more readable?
There was a problem hiding this comment.
It's not the typical style for ArgumentErrors, I think, and hewing to a common style is probably more valuable overall.
| type = identifier1; | ||
| var identifier2 = identifier(); | ||
|
|
||
| if (equalsIgnoreCase(identifier2, "and")) { |
There was a problem hiding this comment.
Sorry, it took me a while to review because I was confused about this part, I was reading the syntax for <media-query> and I didn't realize it had two lines 😅 (the second showing [ not | only ]? <media-type> [ and <media-condition-without-or> ]?)
I didn't realize one could have and like that but not or :)
There was a problem hiding this comment.
Yeah, it has to balance remaining compatible with the legacy syntax even in places where it's confusing with supporting the new syntax.
Also include some code review changes that were meant for #1749
Also include some code review changes that were meant for #1749
| listEquals(other.conditions, conditions); | ||
|
|
||
| int get hashCode => modifier.hashCode ^ type.hashCode ^ listHash(features); | ||
| int get hashCode => modifier.hashCode ^ type.hashCode ^ listHash(conditions); |
There was a problem hiding this comment.
conjunction should be taken into account by equality checks.
See sass/sass#2538
See #1728
See sass/sass-spec#1807