Skip to content

Add bulk email sending functionality and error handling issue #275 #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add bulk email sending functionality and error handling issue #275 #285

wants to merge 5 commits into from

Conversation

@pipinstalled
Copy link

@pipinstalled pipinstalled commented Nov 9, 2025 •
edited
Loading

Base on request on issue no #275

  • Introduced send_messages() method to allow sending multiple emails in a single SMTP session, improving efficiency and reducing overhead.
  • Added EmptyMessagesList exception to handle cases where the messages list is empty.
  • Updated documentation to include examples of bulk email sending.
  • Enhanced tests to cover various scenarios including empty lists and invalid message types.
@pipinstalled
Add bulk email sending functionality and error handling
ef021a9 
- Introduced `send_messages()` method to allow sending multiple emails in a single SMTP session, improving efficiency and reducing overhead.
- Added `EmptyMessagesList` exception to handle cases where the messages list is empty.
- Updated documentation to include examples of bulk email sending.
- Enhanced tests to cover various scenarios including empty lists and invalid message types.
@pipinstalled
Refactor import order and enhance test payload decoding
aa3cc3f 
- Adjusted the import order in `fastmail.py` for better readability.
- Updated the test in `test_connection.py` to decode email payloads before assertions, ensuring accurate content verification for templated messages.
@pipinstalled
Refactor import statement in bulk email example
8046dce
@pipinstalled
Update bulk email example to use NameEmail format for recipients and …
e96b624 
…improve formatting in name email example
@sabuhish
Copy link
Owner

sabuhish commented Nov 10, 2025

Hi @pipinstalled, thanks for the work.
In my opinion, we are repeating ourselves by having the send_messages function.
This function duplicates the logic of send_message, which goes against the DRY principle.
We could use the same function but extend it to accept either a single MessageSchema or a list of them.
This way, it would be simpler for users as well.
@pipinstalled
Refactor bulk email functionality to use send_message() for sending…
2556844 
… multiple messages in one call. Updated documentation and examples accordingly, and modified tests to reflect the new method. Enhanced error handling for empty message lists and invalid message types.
@pipinstalled
Copy link
Author

pipinstalled commented Nov 11, 2025 •
edited
Loading

Hi @pipinstalled, thanks for the work. In my opinion, we are repeating ourselves by having the send_messages function. This function duplicates the logic of send_message, which goes against the DRY principle. We could use the same function but extend it to accept either a single MessageSchema or a list of them. This way, it would be simpler for users as well.

Thanks for your comment I made some changes, please check it and let me know if it needs any change. @sabuhish
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@pipinstalled @sabuhish