-
Notifications
You must be signed in to change notification settings - Fork 77
0.104.0: Take MSRV of 1.83 #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
=======================================
Coverage 97.44% 97.44%
=======================================
Files 20 20
Lines 4104 4104
=======================================
Hits 3999 3999
Misses 105 105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Should we hold off on merging this for a little bit, until we get feedback on the EKU validation API and can merge it? |
cpu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Should merge the following before we release: See also: |
I don't think doing a breaking change just for the MSRV makes sense, as that is uncommon for the ecosystem (MSRV-aware resolver or not). But we have some actually breaking changes that will help. |
Treating this as a breaking change out of caution, as the previous (and new) MSRV doesn't have a MSRV-aware resolver.
re #377