Error on empty EKU extensions #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
==========================================
- Coverage 97.45% 97.43% -0.02%
==========================================
Files 20 20
Lines 4088 4101 +13
==========================================
+ Hits 3984 3996 +12
- Misses 104 105 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ctz
approved these changes
Sep 15, 2025
Member
Author
|
cpu
reviewed
Sep 15, 2025
Comment on lines
+947
to
+948
| let mut empty_eku = untrusted::Reader::new(untrusted::Input::from(&[])); | ||
| let validator = KeyUsage::required_if_present(EKU_SERVER_AUTH); |
Member
There was a problem hiding this comment.
FWIW, I also spot-checked this against a full DER encoded certificate I made with pyca/cryptography adding the EKU extension the same way as the upstream x509-limbo test case and the expected error occurs 👍
#206 is the broader tracking issue to bring that project's coverage in-house.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.