Skip to content

Conversation

@ctz
Copy link
Member

@ctz ctz commented Jul 3, 2025

Sorry, should have caught this in review. ML-DSA is not included in the latest draft submission (https://github.com/aws/aws-lc/blob/main/crypto/fipsmodule/policydocs/DRAFT-140-3-AmazonSecurityPolicy-3.0.0-dynamic.pdf) so shouldn't return true from fips() here irrespective of the underlying FIPS mode.

@codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.53%. Comparing base (5ea4b9b) to head (fb78408).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/aws_lc_rs_algs.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #364   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files          20       20           
  Lines        4094     4094           
=======================================
  Hits         3993     3993           
  Misses        101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@ctz ctz added this pull request to the merge queue Jul 4, 2025
Merged via the queue into main with commit 312d3de Jul 4, 2025
39 of 40 checks passed
@ctz ctz deleted the jbp-mldsa-fips branch July 4, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants