Skip to content

Fix CI build failures, tidy cargo-deny config #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
djc merged 3 commits into from
Apr 4, 2025
Merged

Fix CI build failures, tidy cargo-deny config #339

djc merged 3 commits into from
Apr 4, 2025

Conversation

@cpu
Copy link
Member

@cpu cpu commented Apr 4, 2025

  • Updates semver compat deps to avoid a CMake compatibility issue.
  • Removes RUSTSEC-2024-0436 ignore: it's been fixed upstream in aws-lc-rs.
  • Adds some new flake8 lint ignores to fix the Python testgen task failures.
cpu added 3 commits April 4, 2025 10:15
@cpu
cargo: update semver-compatible dependencies
661a8b7
@cpu
cargo-deny: remove RUSTSEC-2024-0436 ignore
bab0ec7 
This has been fixed in aws-lc-rs upstream.
@cpu
tests: ignore flake8 7.2 false positives
de9aaf8 
Our CI flake8 updated 7.1 -> 7.2 and now reports:

```
./tests/generate.py:690:9: F824 `nonlocal message_path` is unused: name is never assigned in scope
./tests/generate.py:1173:13: F824 `nonlocal crl_paths` is unused: name is never assigned in scope
./tests/generate.py:1173:13: F824 `nonlocal expected_error` is unused: name is never assigned in scope
./tests/generate.py:1173:13: F824 `nonlocal intermediates_str` is unused: name is never assigned in scope
./tests/generate.py:1173:13: F824 `nonlocal ee_cert_path` is unused: name is never assigned in scope
./tests/generate.py:1173:13: F824 `nonlocal root_cert_path` is unused: name is never assigned in scope
```

The values are assigned at a higher scope and while, gross, It Works, so
let's ignore it for now and one day rewrite this mess in Rust :P
@codecov
Copy link

codecov bot commented Apr 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (ab50614) to head (de9aaf8).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #339   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files          20       20           
  Lines        4343     4343           
=======================================
  Hits         4246     4246           
  Misses         97       97

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@djc djc added this pull request to the merge queue Apr 4, 2025
Merged via the queue into rustls:main with commit 55ca2c6 Apr 4, 2025
33 checks passed
@cpu cpu deleted the cpu-fix-build branch April 4, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@cpu @djc @ctz