Skip to content

Conversation

@cpu
Copy link
Member

@cpu cpu commented Mar 20, 2025

No description provided.

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of the Hickory dependency management isn't quite right yet, otherwise looks okay.

"async-trait",
"bytes",
"cfg-if",
"critical-section",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed this with an upstream PR...

"ipnet",
"once_cell",
"rand",
"ring",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this also looks wrong.

source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "1261fe7e33c73b354eab43b1273a57c8f967d0391e80353e51f764ac02cf6775"
dependencies = [
"critical-section",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this...

@cpu
Copy link
Member Author

cpu commented Mar 20, 2025

I think some of the Hickory dependency management isn't quite right yet

D'oh. Thankfully in this repo it's just used in a tools crate that's excluded from the workspace defaults & not published. Happy to hear it's getting fixed upstream anyway, thank you.

@cpu cpu merged commit 79a0d38 into rustls:main Mar 20, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants