Add Windows ASAN testing #482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rustls switched to `aws-lc-rs` to use the `prebuilt-nasm` in Rustls 0.23.16+ This means we no longer need to install NASM in the Windows CI workflows that use aws-lc-rs.
This commit updates the `tests/CMakeLists.txt` configuration for building the client/server examples on Windows to enable address sanitizer (ASAN). We were already doing this for Linux and MacOS builds but were missing Windows coverage. Notably this requires a modern MSVC configured on the $PATH at runtime so that the ASAN DLLs are present. Otherwise the built binaries cryptically exit immediately with no output, just the exit status -1073741515. We use the setup-msvc-dev action in CI to do this for us. See the Microsoft documentation for more information: https://devblogs.microsoft.com/cppblog/addresssanitizer-asan-for-windows-with-msvc/#compiling-with-asan-from-the-console
ctz
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci: remove NASM install for Windows/aws-lc-rs
Rustls switched
aws-lc-rsto use theprebuilt-nasmfeature in Rustls 0.23.16+ This means we no longer need to install NASM in the Windows CI workflows that use aws-lc-rs.build Windows debug client/server with ASAN
This commit updates the
tests/CMakeLists.txtconfiguration for building the client/server examples on Windows to enable address sanitizer (ASAN). We were already doing this for Linux and MacOS builds but were missing Windows coverage.Notably this requires a modern MSVC configured on the
$PATHat runtime so that the ASAN DLLs are present. Otherwise the built binaries cryptically exit immediately with no output, just the exit status-1073741515. We use the setup-msvc-dev action in CI to do this for us (but only for the debug profile workflows).You can confirm that ASAN is being used in the output of a debug build where we see a new warning:
See the Microsoft ASAN documentation for more information.