Makefile: limit scope of format/format-check #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctz
approved these changes
Apr 4, 2024
Member
Author
|
This is manifesting as a spurious format failure over in this other branch |
Member
|
Ah, I think this is now evading the |
We don't want `.git` or `target/` or other misc dirs to be subject to these phony targets.
cpu
force-pushed
the
cpu-fix-format-scope
branch
from
f1d6fe4 to
8ac5d77
Compare
Member
Author
Fixed up. I also removed the now-unneeded target dir exclusion. |
Member
Author
|
Simple test-only fix. Going to merge once CI passes so that #414 can be rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want
.gitortarget/or other misc dirs to be subject to these phony targets.Inspired by ctz fixing the same in the compat repo.