ci: add Linux pkg-config/.so test coverage #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu
force-pushed
the
cpu-pkg-config-ci-cov
branch
from
56f432e to
8736fcd
Compare
cpu
commented
Apr 4, 2024
A new `Makefile.pkg-config` is added that can be used on UNIX machines with `pkg-config`. It is a slimmed down copy of `Makefile` that: * Removes the development targets (`format`, etc). * Removes details specific to static linking. * Uses `cargo cinstall` for the install target. * Adds the correct `CFLAGS`/`LDFLAGS` that `pkg-config` tells us are necessary based on the `.pc` file that `cargo-c` writes. * Runs the integration tests with the dynamically linked client/server examples. A new CI workflow (`pkg-config.yaml`) is added that only runs on ubuntu-latest (with both `clang` and `gcc`) that: * Installs stable rust. * Installs `cargo-c`. * Installs the lib to a tmp dir using `cargo-c`. * Builds the client/server examples using `pkg-config` to dynamically link `rustls`. * Verify the binaries aren't statically linking `rustls`. * Run the client/server integration tests. The existing `cargo-c` coverage is removed from the `test.yaml` workflow since it's now duplicative with this new workflow.
cpu
force-pushed
the
cpu-pkg-config-ci-cov
branch
from
8736fcd to
56b8d5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow-up to #274 that adds test coverage for using rustls with pkg-config and dynamic linking. A new
Makefile.pkg-configis added that can be used on UNIX machines withpkg-config. It is a slimmed down copy ofMakefilethat:format, etc).cargo cinstallfor the install target.CFLAGS/LDFLAGSthatpkg-configtells us are necessary based on the.pcfile thatcargo-cwrites.A new CI workflow (
pkg-config.yaml) is added that only runs on ubuntu-latest (with bothclangandgcc) that:cargo-c.cargo-c.pkg-configto dynamically linkrustls.rustls.The existing
cargo-ccoverage is removed from thetest.yamlworkflow since it's now duplicative with this new workflow.