Nightly clippy fixes. #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New nightly clippy is flagging one of the lines of rustdoc comment in `lib.rs`: > error: this item has comments with 4 forward slashes (`////`). These > look like doc comments, but they aren't The fix is simple, use only 3 forward slashes :-)
Nightly clippy is flagging a redundant call in `cipher.rs`: > call to `.deref()` on a reference in this situation does nothing This commit removes the call to `deref` and also the now unnecessary import of the `std::ops::Deref` trait.
ctz
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small branch fixing some failures caught by the cron CI job's nightly clippy task.
lib: fix small rustdoc mistake
New nightly clippy is flagging one of the lines of rustdoc comment in
lib.rs:The fix is simple, use only 3 forward slashes :-)
cipher: remove redundant call.
Nightly clippy is flagging a redundant call in
cipher.rs:This commit removes the call to
derefand also the now unnecessary import of thestd::ops::Dereftrait.