Skip to content

Shrink unsafe block #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cpu merged 1 commit into from
Aug 3, 2023
Merged

Shrink unsafe block #271

cpu merged 1 commit into from
Aug 3, 2023

Conversation

@cactter
Copy link
Contributor

@cactter cactter commented Jul 22, 2022

No description provided.

@cpu
Copy link
Member

cpu commented Aug 2, 2023

@jsha Is there a reason you would prefer the unsafe blocks as-written, or should this be considered for rebasing + review?
@jsha
Copy link
Collaborator

jsha commented Aug 3, 2023

This is suitable for rebasing + review!
@cpu
Copy link
Member

cpu commented Aug 3, 2023

This is suitable for rebasing + review!

Sounds good. Rebased + fixed formatting errors.
@cpu cpu requested review from ctz and jsha August 3, 2023 13:30
@cpu
Copy link
Member

cpu commented Aug 3, 2023

I think this change is small enough in scope I'm comfortable merging with one positive review. If there's any additional feedback I will commit to iterating on the unreleased code in main.
@cpu cpu merged commit db40a7b into rustls:main Aug 3, 2023
@cpu
Copy link
Member

cpu commented Aug 3, 2023

Thanks @cactter !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@cactter @cpu @jsha @ctz