Repository navigation
const_generics: Fix incorrect ty::ParamEnv::empty() usage - #82067
Merged
Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
lcnr
reviewed
Feb 13, 2021
BoxyUwU
force-pushed
the
hahaicantthinkofabadpun
branch
from
February 13, 2021 19:10
b3d8781 to
a419e11
Compare
oli-obk
requested changes
Feb 14, 2021
oli-obk
left a comment
oli-obk
left a comment
Contributor
There was a problem hiding this comment.
just lots of tracing changes, the actual changes lgtm
Comment on lines
+96
to
+100
| debug!("resolve(def.did={:?}, substs={:?}) = {:?}", def.did, substs, result); | ||
| debug!( | ||
| "inner_resolve_instance: resolve(def.did={:?}, substs={:?}) = {:?}", | ||
| def.did, substs, result | ||
| ); |
Contributor
There was a problem hiding this comment.
after that change, you can just print the result here (though I think there's also a way to tell #[instrument] to do that
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 7bd7126 has been approved by |
bors
added
S-waiting-on-bors
This was referenced Feb 15, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 16, 2021
…as-schievink Rollup of 19 pull requests Successful merges: - rust-lang#81503 (Suggest to create a new `const` item if the `fn` in the array is a `const fn`) - rust-lang#81897 (Add match pattern diagnostics regression test) - rust-lang#81975 (Seal the CommandExt, OsStrExt and OsStringExt traits) - rust-lang#82009 (const_generics: Dont evaluate array length const when handling errors) - rust-lang#82060 (Fix typos in BTreeSet::{first, last} docs) - rust-lang#82061 (CTFE validation: catch ReadPointerAsBytes and better error) - rust-lang#82063 (Fixed minor typo in catch_unwind docs) - rust-lang#82067 (const_generics: Fix incorrect ty::ParamEnv::empty() usage) - rust-lang#82077 (Edit `rustc_arena::DropArena` docs) - rust-lang#82096 (Fix a typo) - rust-lang#82106 (Remove unnecessary `Option` in `default_doc`) - rust-lang#82107 (expand: Some cleanup) - rust-lang#82118 (Add missing env!-decl variant) - rust-lang#82119 (Fix typo in link to CreateSymbolicLinkW documentation.) - rust-lang#82120 (Stabilize Arguments::as_str) - rust-lang#82129 (Remove redundant bool_to_option feature gate) - rust-lang#82133 (Update link for extern prelude.) - rust-lang#82141 (32-bit ARM: Emit `lr` instead of `r14` when specified as an `asm!` output register.) - rust-lang#82147 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
3 of 16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80561
Not sure if I should keep the
debug!(..)s or not but its the second time I've needed them so they sure seem useful lolcc @lcnr
r? @oli-obk