Repository navigation
Suggest accessing field when appropriate - #81504
Merged
Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
estebank
reviewed
Jan 29, 2021
estebank
reviewed
Jan 29, 2021
estebank
reviewed
Jan 29, 2021
estebank
reviewed
Jan 29, 2021
Contributor
|
Minor nitpicks. Ping me when done and I'll r=me once addressed. |
Contributor
Author
|
@estebank Review applied. |
estebank
reviewed
Jan 30, 2021
Contributor
|
I'm really happy with the results, thanks for taking the time! r=me after tackling the last nitpick if you have the time, otherwise please file a follow up ticket so that someone can fix it after landing this PR. |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit f45a993 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 1, 2021
…as-schievink Rollup of 12 pull requests Successful merges: - rust-lang#78641 (Let io::copy reuse BufWriter buffers) - rust-lang#79291 (Add error message for private fn) - rust-lang#81364 (Improve `rustc_mir_build::matches` docs) - rust-lang#81387 (Move some tests to more reasonable directories - 3) - rust-lang#81463 (Rename NLL* to Nll* accordingly to C-CASE) - rust-lang#81504 (Suggest accessing field when appropriate) - rust-lang#81529 (Fix invalid camel case suggestion involving unicode idents) - rust-lang#81536 (Indicate both start and end of pass RSS in time-passes output) - rust-lang#81592 (Rustdoc UI fixes) - rust-lang#81594 (Avoid building LLVM just for llvm-dwp) - rust-lang#81598 (Fix calling convention for CRT startup) - rust-lang#81618 (Sync rustc_codegen_cranelift) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Feb 2, 2021
…ewording, r=estebank Improve wording of suggestion about accessing field Follow-up to rust-lang#81504 The compiler at this moment suggests "you might have meant to use field `b` of type `B`", sounding like it's type `B` which has the field `b`. r? `@estebank`
jackh726
added a commit
to jackh726/rust
that referenced
this pull request
Feb 2, 2021
…ewording, r=estebank Improve wording of suggestion about accessing field Follow-up to rust-lang#81504 The compiler at this moment suggests "you might have meant to use field `b` of type `B`", sounding like it's type `B` which has the field `b`. r? ``@estebank``
jackh726
added a commit
to jackh726/rust
that referenced
this pull request
Feb 2, 2021
…ewording, r=estebank Improve wording of suggestion about accessing field Follow-up to rust-lang#81504 The compiler at this moment suggests "you might have meant to use field `b` of type `B`", sounding like it's type `B` which has the field `b`. r? ```@estebank```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #81222
r? @estebank