Repository navigation
Tags: rshest/flow
Tags
fix missing dependency Summary: CommandHandler directly uses Js_layout_generator but didn't depend on it. implicitly relying on something else to include it is fragile and broke on the 201 branch. Changelog: [internal] Reviewed By: SamChou19815 Differential Revision: D43737643 fbshipit-source-id: 8e700d715fe47ea7f671e908451d75d8e74f0233
Fix missing `exact_by_default` flag in `tests/tvars` Summary: Result of a land race between D42970432 (meta@829111b) and D43075102 (meta@aaa8f6c) Changelog: [internal] Reviewed By: samwgoldman, SamChou19815 Differential Revision: D43142371 (meta@9c7338d) ------------------------------------------------------------------------ (from 1a51801fc4637a80b1ca670783824af04df7a08d) fbshipit-source-id: 15c0f302892f0d1d74821f1b900ec769cb60d435
v0.199.1 Summary: (Note: this ignores all push blocking failures!) Reviewed By: SamChou19815 Differential Revision: D42975918 (meta@f975b22) ------------------------------------------------------------------------ (from 9c3e5896d9661a29c4d8903b72b874a0154c6b95) fbshipit-source-id: 64eb23fd2e9b16760734a500d187522f1d7c42ad
fix missing errors when a file is deleted before init in lazy mode Summary: when a file is deleted, we need to dirty the haste module it provides so that a new provider can be picked (or no provider), and dependents can be rechecked. when a file is deleted before the server starts, we can't parse it to extract its `providesModule`. if the file is using haste name reducers, where the module name is derived from the file name instead of `providesModule`, we know which module to dirty just from the "changes since mergebase" scm query. if we're using saved state, the deleted provider is available when we parse the files changed since the saved state during init, but we ignore `changed_modules` in `init_from_saved_state`. since the file is also changed since mergebase, we also "recheck" it right after init and have to guess from the filename since it's already gone from shared mem. that isn't fixed in this diff. so lazy mode correctness relies on using git or hg, and using haste name reducers. with some additional work, I think we could also make it correct without haste reducers, when using saved state. Changelog: [fix] Fix an issue with lazy mode where deleting a file before the server starts did not check files that were depending on the deleted file. Reviewed By: samwgoldman Differential Revision: D42941765 (meta@35940c3) ------------------------------------------------------------------------ (from 827697dda0fa9c258cefcdd74d5ae6429f38e5cf) fbshipit-source-id: 814f8bf784107bebef6332764d7965b614da1f62
Fix code action service tests to read committed data Summary: Instead of rolling back every transaction, we need to commit the transaction first, so we can use a State_reader to read the committed data back. So, this diff changes the tests to commit transactions instead. After we commit, we can run the function under test. After that, we run another transaction to remove the file. Reviewed By: mroch Differential Revision: D42199510 fbshipit-source-id: 1c5eb09cab4e05fb05303a49721e3785319f73cd
PreviousNext