Skip to content

Conversation

@mini-1235
Copy link
Collaborator

@mini-1235 mini-1235 commented Jan 26, 2026


Basic Info

Info Please fill out this column
Ticket(s) this addresses closes #4659
Primary OS tested on Ubuntu
Robotic platform tested on Tb4
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)
Was this PR description generated by AI software? Out of respect for maintainers, AI for human-to-human communications are banned

Description of contribution in a few bullet points

Description of documentation updates required from your changes

Description of how this change was tested


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
...tree/include/nav2_behavior_tree/bt_action_node.hpp 77.27% <100.00%> (+3.22%) ⬆️
...ee/include/nav2_behavior_tree/bt_action_server.hpp 83.33% <ø> (ø)
...clude/nav2_behavior_tree/bt_action_server_impl.hpp 88.94% <100.00%> (-0.75%) ⬇️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename to cancel_timeout instead, I think that's more clear. It is used in Halt, but it is for cancellations. Otherwise LGTM

Edit: Ditto with the docs PR. Also add to the migration guide and the reason 'why'. I think that breadcrumb trail could help the next person with this error easily.

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
@mini-1235 mini-1235 closed this Jan 26, 2026
@mini-1235 mini-1235 reopened this Jan 26, 2026
@mini-1235
Copy link
Collaborator Author

I am not sure why github sometimes close my PR when I push a commit :(

@mini-1235 mini-1235 changed the title Add halt timeout when cancelling actions Jan 26, 2026
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
@SteveMacenski SteveMacenski merged commit 640196a into ros-navigation:main Jan 26, 2026
17 checks passed
mergify bot pushed a commit that referenced this pull request Jan 26, 2026
* Add halt timeout when cancelling actions

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Add to config

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix flaky test

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Retrigger

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Rename

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Lint

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
(cherry picked from commit 640196a)

# Conflicts:
#	nav2_behavior_tree/include/nav2_behavior_tree/bt_action_server_impl.hpp
#	nav2_system_tests/src/system/nav2_system_params.yaml
mergify bot pushed a commit that referenced this pull request Jan 26, 2026
* Add halt timeout when cancelling actions

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Add to config

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix flaky test

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Retrigger

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Rename

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Lint

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
(cherry picked from commit 640196a)

# Conflicts:
#	nav2_behavior_tree/include/nav2_behavior_tree/bt_action_server_impl.hpp
@mini-1235 mini-1235 deleted the fix/bt branch January 26, 2026 19:57
@mini-1235
Copy link
Collaborator Author

Do you want me to do the backports manually?

@SteveMacenski
Copy link
Member

Yeah, the autobackports failed

@mini-1235
Copy link
Collaborator Author

will do tomorrow, I am heading to bed now :)

Prathmesh2931 pushed a commit to Prathmesh2931/navigation2 that referenced this pull request Jan 27, 2026
* Add halt timeout when cancelling actions

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Add to config

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix flaky test

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Retrigger

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Rename

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Lint

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment