-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add cancel timeout when cancelling actions #5895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 25 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename to cancel_timeout instead, I think that's more clear. It is used in Halt, but it is for cancellations. Otherwise LGTM
Edit: Ditto with the docs PR. Also add to the migration guide and the reason 'why'. I think that breadcrumb trail could help the next person with this error easily.
|
I am not sure why github sometimes close my PR when I push a commit :( |
* Add halt timeout when cancelling actions Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add to config Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix flaky test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Retrigger Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Rename Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> (cherry picked from commit 640196a) # Conflicts: # nav2_behavior_tree/include/nav2_behavior_tree/bt_action_server_impl.hpp # nav2_system_tests/src/system/nav2_system_params.yaml
* Add halt timeout when cancelling actions Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add to config Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix flaky test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Retrigger Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Rename Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> (cherry picked from commit 640196a) # Conflicts: # nav2_behavior_tree/include/nav2_behavior_tree/bt_action_server_impl.hpp
|
Do you want me to do the backports manually? |
|
Yeah, the autobackports failed |
|
will do tomorrow, I am heading to bed now :) |
* Add halt timeout when cancelling actions Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add to config Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix flaky test Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Retrigger Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Rename Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.