-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add symmetric goal for goal checker and mppi goal angle critic #5833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Co-authored-by: Sandeep Dutta <quark01@gmail.com>
Codecov Report❌ Patch coverage is
... and 28 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com>
|
@claude please backport this PR to Kilted, Jazzy, and Humble branch |
@SteveMacenski should I open an issue for this? Or could you please help me to trigger this so that I don't have to backport manually :) |
|
Go to "labels" and you should see a label for backporting to various distributions. If you just add that, a backport is automatically triggered using Mergify. I don't think this can be backported automatically though since MPPI using Eigen here but xtensor in other distributions. Its probably not 1:1. An LLM agent is probably overkill 😆 |
|
Ok, I will just backport it manually since the author is requesting this feature in humble |
|
I noticed that this actually breaks the ABI since we are adding member to it, is it OK to backport? |
|
I don't worry about that as much currently. If it changes function signatures that are currently in use or changes the behavior of someone not using the feature, that's when I draw the line. Subjectively, also when the change is "large" enough that while I think it should be fine, out of risk management for existing users I would opt to not backport and make it a new feature in a new distribution to give it soaking time for issues to be uncovered. The most important thing is to not break any current users in that distribution in terms of compilation or behavior. New methods / members I think are OK as long as its confined to the inner workings of the class and no user impact could be predicted. Except for the BT Engine, where I know there are lots of users outside of Nav2, so I do not allow any breaks there. Technically we shouldn't backport new members / methods, but I don't think that's in the spirit of the intent (and then we just wouldn't backport anything). If anyone challenged that policy due to need, then I've always been up to revisiting that, but so far none have. |
…avigation#5833) * Add symmetric goal for goal checker and mppi goal angle critic Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Co-authored-by: Sandeep Dutta <quark01@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Update nav2_mppi_controller/README.md Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> Co-authored-by: Sandeep Dutta <quark01@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
|
Got it :) |
…avigation#5833) * Add symmetric goal for goal checker and mppi goal angle critic Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Co-authored-by: Sandeep Dutta <quark01@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Update nav2_mppi_controller/README.md Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> Co-authored-by: Sandeep Dutta <quark01@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
…avigation#5833) * Add symmetric goal for goal checker and mppi goal angle critic Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Co-authored-by: Sandeep Dutta <quark01@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Update nav2_mppi_controller/README.md Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> Co-authored-by: Sandeep Dutta <quark01@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
#5847) * Add symmetric goal for goal checker and mppi goal angle critic * Lint * Update nav2_mppi_controller/README.md --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> Co-authored-by: Sandeep Dutta <quark01@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
#5848) * Add symmetric goal for goal checker and mppi goal angle critic * Lint * Update nav2_mppi_controller/README.md --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> Co-authored-by: Sandeep Dutta <quark01@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
…ort humble) (#5849) * Add symmetric goal for goal checker and mppi goal angle critic (#5833) * Add symmetric goal for goal checker and mppi goal angle critic Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Co-authored-by: Sandeep Dutta <quark01@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Update nav2_mppi_controller/README.md Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> Co-authored-by: Sandeep Dutta <quark01@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix tests Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> Co-authored-by: Sandeep Dutta <quark01@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
…avigation#5833) * Add symmetric goal for goal checker and mppi goal angle critic Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Co-authored-by: Sandeep Dutta <quark01@gmail.com> * Lint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Update nav2_mppi_controller/README.md Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice Alexander Purnawan <mauricepurnawan@gmail.com> Co-authored-by: Sandeep Dutta <quark01@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.