Skip to content

Conversation

@Tacha-S
Copy link
Contributor

@Tacha-S Tacha-S commented Jun 12, 2025


Basic Info

Info Please fill out this column
Ticket(s) this addresses #4601
Primary OS tested on Ubuntu
Robotic platform tested on gazebo simulation, our mobile robot hardware
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

Description of documentation updates required from your changes

Description of how this change was tested

Tested on sim and my hardware, wrote some new unit tests


Future work that may be required in bullet points

Maybe more unit tests? Looking for some suggestions before proceeding

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
Signed-off-by: Tatsuro Sakaguchi <tatsuro.sakaguchi@g.softbank.co.jp>
@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2025

@Tacha-S, all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @jazzy, but it must be in main
to have these changes reflected into new distributions.

@codecov
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...nav2_mppi_controller/models/optimizer_settings.hpp 100.00% <ø> (ø)
...ler/include/nav2_mppi_controller/motion_models.hpp 100.00% <100.00%> (ø)
nav2_mppi_controller/src/optimizer.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, no notes!

@SteveMacenski SteveMacenski merged commit b47bcfa into ros-navigation:jazzy Jun 12, 2025
11 checks passed
RBT22 pushed a commit to EnjoyRobotics/navigation2 that referenced this pull request Sep 11, 2025
)

Signed-off-by: Tatsuro Sakaguchi <tatsuro.sakaguchi@g.softbank.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants