Skip to content

Replace global variable with global variables in the gtest of nav2_system_tests #4978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

Replace global variable with global variables in the gtest of nav2_system_tests #4978

merged 1 commit into from
Mar 11, 2025

Conversation

@evshary
Copy link
Contributor

@evshary evshary commented Mar 11, 2025

Basic Info

Info Please fill out this column
Ticket(s) this addresses -
Primary OS tested on Ubuntu
Robotic platform tested on -
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

Miss one test while replacing global variables in #4948

Description of documentation updates required from your changes

No

Description of how this change was tested

Run the system tests

Future work that may be required in bullet points

No

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
@evshary
Use main function to replace global variable in gtest.
bd7b825 
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
@codecov
Copy link

codecov bot commented Mar 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@SteveMacenski SteveMacenski merged commit ee96246 into ros-navigation:main Mar 11, 2025
11 checks passed
@evshary evshary deleted the fix_missing branch March 12, 2025 02:07
SteveMacenski pushed a commit that referenced this pull request Apr 15, 2025
@evshary @SteveMacenski
Use main function to replace global variable in gtest. (#4978)
049bb74 
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
SteveMacenski added a commit that referenced this pull request Apr 15, 2025
@SteveMacenski @mini-1235
@georgflick @BCKSELFDRIVEWORLD @mattbooker @evshary @DylanDeCoeyer-Quimesis @RasmusLar @ajtudela
Jazz sync - April 15, 2025 (#5090)
7e31b88 
* Add short delay before lookup transform in polygon test (#4939)

* Add short delay before lookup transform

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix linting

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Populate stamped command message with now timestamp, if velocity timed out. (#4959)

Signed-off-by: Georg Flick <georg.flick@enway.ai>

* Integrate ClearCostmapExceptRegion and ClearCostmapAroundRobot Services into the API (#4962)

* Add ClearCostmapExceptRegion and ClearCostmapAroundRobot services to BasicNavigator API

Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>

* typo ament_flake8

Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>

* type fix ament_flake

Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>

---------

Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>

* Fix urls in node hybrid (#4973)

Signed-off-by: mattbooker <mattbooker97@gmail.com>

* Use main function to replace global variable in gtest. (#4978)

Signed-off-by: ChenYing Kuo <evshary@gmail.com>

* nav2_behavior_tree: fix input port parsing error in AreErrorCodesPresent (#4986)

The getInput method does not support std::set<uint16_t> parsing. So,
let's replace the type of the input port by std::vector<int> which is
supported, and convert the list to a std::set<uint16_t>.

This commit fixes issue #4985.

Signed-off-by: Dylan De Coeyer <dylan.decoeyer@quimesis.be>

* Change to goal checker orientation for yaw angle (#4988)

- Fixed discrepancy in goal checker orientation, which was checking for
< tolerance instead of <= tolerance, as all the other limit checks are.
- Reduced tolerance time for the progress checker unit tests to
0.1 seconds, to reduce test runtime from ~17 to ~7 seconds.

Signed-off-by: Rasmus Larsson <rasmus.larsson@accenture.com>

* Declare_parameter_if_not_declared in docking navigator (#5023)

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* bumping to 1.3.6 for release

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Georg Flick <georg.flick@enway.ai>
Signed-off-by: BCKSELFDRIVEWORLD <bckselfdrive@gmail.com>
Signed-off-by: mattbooker <mattbooker97@gmail.com>
Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: Dylan De Coeyer <dylan.decoeyer@quimesis.be>
Signed-off-by: Rasmus Larsson <rasmus.larsson@accenture.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: mini-1235 <58433591+mini-1235@users.noreply.github.com>
Co-authored-by: Georg Flick <54032815+georgflick@users.noreply.github.com>
Co-authored-by: Burak Can Kaya <146545020+BCKSELFDRIVEWORLD@users.noreply.github.com>
Co-authored-by: Matthew Booker <mattbooker97@gmail.com>
Co-authored-by: ChenYing Kuo (CY) <evshary@gmail.com>
Co-authored-by: DylanDeCoeyer-Quimesis <102609575+DylanDeCoeyer-Quimesis@users.noreply.github.com>
Co-authored-by: RasmusLar <101558931+RasmusLar@users.noreply.github.com>
Co-authored-by: Alberto Tudela <ajtudela@gmail.com>
stevedanomodolor pushed a commit to stevedanomodolor/navigation2 that referenced this pull request Apr 29, 2025
@evshary @stevedanomodolor
Use main function to replace global variable in gtest. (ros-navigatio…
ff5ab61 
…n#4978)

Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: stevedanomodolor <stevedan.o.omodolor@gmail.com>
SakshayMahna pushed a commit to SakshayMahna/navigation2 that referenced this pull request Jun 8, 2025
@evshary @SakshayMahna
Use main function to replace global variable in gtest. (ros-navigatio…
7a04c05 
…n#4978)

Signed-off-by: ChenYing Kuo <evshary@gmail.com>
Signed-off-by: Sakshay Mahna <sakshum19@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@evshary @SteveMacenski