-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add acceleration limits to DriveOnHeading and BackUp behaviors #4810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SteveMacenski
merged 16 commits into
ros-navigation:main
from
EnjoyRobotics:rolling/acc-drive-on-heading
Jan 28, 2025
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8bb038d
Add acceleration constraints
RBT22 5ff40c6
Cleanup code
RBT22 7e398a7
Format code
RBT22 af27102
Add <limits> header to drive_on_heading.hpp
RBT22 f584a0e
Remove vel pointer
RBT22 e35aa17
Use the limits only if both of them is set
RBT22 fb21167
Fix onActionCompletion params
RBT22 66c775d
Add default acc params and change decel sign
RBT22 a8b6221
Add minimum speed parameter
RBT22 fb92e14
Update minimum speed parameter to 0.10
RBT22 a8fe01d
Log warning when acceleration or deceleration limits are not set
RBT22 a854c74
Add param sign assert
RBT22 964404a
Remove unnecessary param checking
RBT22 7214eb9
Refactor acceleration limits to handle forward and backward movement …
RBT22 dd3b744
Fix sign checking condition
RBT22 80ffedf
Replace throwing with silent sign correction
RBT22 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add param sign assert
Signed-off-by: RBT22 <rozgonyibalint@gmail.com>
- Loading branch information
commit a854c74035aa4ab933dc6e6372d7288835290df2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.