Skip to content

Added collision detection for docking (backport #4752) #4758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2024
Merged

Added collision detection for docking (backport #4752) #4758

merged 1 commit into from
Nov 21, 2024

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 21, 2024

Basic Info

Info Please fill out this column
Ticket(s) this addresses #4404
Primary OS tested on Ubuntu 24.04
Robotic platform tested on Morphia
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

  • Added optional collision checking on docking / undocking.

Description of documentation updates required from your changes

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
This is an automatic backport of pull request #4752 done by [Mergify](https://mergify.com).
@ajtudela @mergify
Added collision detection for docking (#4752)
9b41e7a 
* Added collision detection for docking

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Minor fixes

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Improve collision  while undocking and test

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Fix smoke testing

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Rename dock_collision_threshold

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Added docs and params

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

* Minor changes in README

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>

---------

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
(cherry picked from commit 90a6c8d)
@mergify
Copy link
Contributor Author

mergify bot commented Nov 21, 2024

@mergify[bot], all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @jazzy, but it must be in main
to have these changes reflected into new distributions.
@SteveMacenski SteveMacenski merged commit 2da6aa8 into jazzy Nov 21, 2024
7 of 8 checks passed
@SteveMacenski SteveMacenski deleted the mergify/bp/jazzy/pr-4752 branch November 21, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@SteveMacenski @ajtudela