Added costmap in goal_checker plugins #2965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@hardesh, please properly fill in PR template in the future. @SteveMacenski, use this instead.
|
SteveMacenski
requested changes
May 24, 2022
Member
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
LGTM conceptually, just a couple of tiny changes.
The biggest thing that also needs updated are
- Migration guide entry that we made this change
nav2_controller/include/nav2_controller/plugins/simple_goal_checker.hpp
Outdated
Show resolved
Hide resolved
nav2_controller/include/nav2_controller/plugins/stopped_goal_checker.hpp
Outdated
Show resolved
Hide resolved
SteveMacenski
approved these changes
May 26, 2022
Member
There was a problem hiding this comment.
LGTM, please add a section to the migration guide about the API change to the goal checkers https://navigation.ros.org/migration/Galactic.html, it'll make it into Humble
Contributor
Author
|
I've opened a PR in the docs repository. Missed it yesterday |
Member
|
You have a linting error but then can merge |
redvinaa
pushed a commit
to EnjoyRobotics/navigation2
that referenced
this pull request
Jun 30, 2022
* Added costmap in the goal checker * Added costmap in goal_checker * Adressed comments in PR * Fixed linting error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2939
Tested the build with ROS2 Humble