Move dwb goal/progress checker plugins to nav2_controller #1857

siddhya · 2020-07-07T14:00:51Z

Signed-off-by: Siddarth Gore siddarth.gore@gmail.com

Basic Info

Info	Please fill out this column
Ticket(s) this addresses	#1390
Primary OS tested on	Ubuntu 20.04 (WSL)
Robotic platform tested on	colcon test

Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

SteveMacenski · 2020-07-07T19:10:48Z

Check the linters ament_cpplint ament_cppcheck ament_uncrustify, you have some failures that is failing CI

SteveMacenski

I have a few more things I want to think about, but this looks good as a concept. There's a few topics below to discuss and after those are fixed, we can get into the more logic update items I'm thinking about.

nav2_controller/CMakeLists.txt

nav2_controller/plugins.xml

nav2_dwb_controller/dwb_core/src/dwb_local_planner.cpp

nav2_controller/plugins/simple_progress_checker.cpp

SteveMacenski · 2020-07-07T19:23:23Z

Thanks for taking this on! Looks good conceptually, after those things are fixed I'll narrow more into the nav2_controller server to make sure the resets / updates look good.

Address review comments Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

codecov · 2020-07-08T09:52:31Z

Codecov Report

Merging #1857 into master will decrease coverage by 0.56%.
The diff coverage is 85.18%.

@@            Coverage Diff             @@
##           master    #1857      +/-   ##
==========================================
- Coverage   69.25%   68.69%   -0.57%     
==========================================
  Files         218      218              
  Lines       10604    10609       +5     
==========================================
- Hits         7344     7288      -56     
- Misses       3260     3321      +61

Flag	Coverage Δ
#project	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...roller/include/nav2_controller/nav2_controller.hpp	`100.00% <ø> (ø)`
nav2_core/include/nav2_core/controller.hpp	`100.00% <ø> (ø)`
...er/dwb_core/include/dwb_core/dwb_local_planner.hpp	`100.00% <ø> (ø)`
..._dwb_controller/dwb_core/src/dwb_local_planner.cpp	`75.68% <ø> (-1.65%)`	⬇️
nav2_core/include/nav2_core/progress_checker.hpp	`50.00% <50.00%> (ø)`
nav2_controller/src/nav2_controller.cpp	`79.01% <80.00%> (-0.37%)`	⬇️
nav2_controller/plugins/simple_goal_checker.cpp	`100.00% <100.00%> (ø)`
...av2_controller/plugins/simple_progress_checker.cpp	`100.00% <100.00%> (ø)`
nav2_controller/plugins/stopped_goal_checker.cpp	`100.00% <100.00%> (ø)`
nav2_recoveries/plugins/spin.cpp	`0.00% <0.00%> (-89.48%)`	⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4755a1e...30740cf. Read the comment docs.

SteveMacenski

Last few issues - checked the logic and I'm good with everything else.

Doc updates
Plugin param reading consistency

nav2_controller/plugins/simple_goal_checker.cpp

nav2_controller/src/nav2_controller.cpp

Use new plugin declaration format and doc update Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

SteveMacenski

OK just some logistics left. Adding params for plugins and namespace corrections to the yaml files and the above request for documentation.

@Marwan99 can you sanity check me that these updates in the md file and website are correct?

doc/parameters/param_list.md

Also remove redundent file from dwb_plugins Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

doc/parameters/param_list.md

Marwan99 · 2020-07-13T17:29:29Z

I think the params below need to be removed (sorry couldn't comment on them in a review nor link them here)

<dwb plugin>.goal_checker_name in dwb_local_planner
required_movement_radius in controller_server
movement_time_allowance in controller_server

nav2_bringup/bringup/params/nav2_params.yaml

Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

SteveMacenski · 2020-07-14T17:45:08Z

@Marwan99 please review

Marwan99

Thanks for addressing the previous comments, just a couple of minor things. Along with the two mentioned below and this also needs to be documented (it is not related to this work but we might as well add it now).

Also please don't forget to remove the param below

.goal_checker_name in dwb_local_planner

nav2_controller/src/nav2_controller.cpp

Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

declare .plugin only if not declared before Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

SteveMacenski · 2020-07-16T19:12:18Z

@Marwan99 please take another look!

Marwan99 · 2020-07-17T02:44:10Z

nav2_controller/plugins/test/progress_checker.cpp

+  nav2_core::ProgressChecker * pc = new SimpleProgressChecker;
+  pc->reset();
+  delete pc;
+  EXPECT_TRUE(true);


I don't understand how the reset method is being tested. Also, do we need EXPECT_TRUE(true);?

Making sure it doesn't crash as the next test is dependent on it. EXPECT_TRUE is used as a convention for returning from TEST functions. I have based these tests on the already available goal_checker tests.

Ah alright, thanks for explaining it:)

Marwan99 · 2020-07-17T02:50:50Z

doc/parameters/param_list.md

 | ----------| --------| ------------|
 | controller_frequency | 20.0 | Frequency to run controller |
 | progress_checker_plugin | "progress_checker" | Check the progress of the robot |
+| progress_checker.plugin | "nav2_controller::SimpleProgressChecker" | Default plugin |


Along side mentioning that this is default plugin class for progress_checker, can we mention that "progress_checker" in progress_checker.plugin parameter name is coming from the progress_checker_plugin parameter? And that it should correspond to whatever plugin class name intended to be used.

Ya I was wondering what the right convention is here. <progress checker_plugin>.plugin?

Yeah that would work - I think you could also just check what was done for the planner / controller plugins that were already updated and just mirror it

Done. No other .plugin param is mentioned in this file yet.

Marwan99 · 2020-07-17T02:51:10Z

doc/parameters/param_list.md

 | progress_checker_plugin | "progress_checker" | Check the progress of the robot |
+| progress_checker.plugin | "nav2_controller::SimpleProgressChecker" | Default plugin |
 | goal_checker_plugin | "goal_checker" | Check if the goal has been reached |
+| goal_checker.plugin | "nav2_controller::SimpleGoalChecker" | Default plugin |


doc/parameters/param_list.md

Marwan99 · 2020-07-17T02:53:20Z

doc/parameters/param_list.md

 | Parameter | Default | Description |
 | ----------| --------| ------------|
 | controller_frequency | 20.0 | Frequency to run controller |
 | progress_checker_plugin | "progress_checker" | Check the progress of the robot |


Should we explain what is meant by progress?

Can you provide a suggested text?

Plugin used by the controller to check whether the robot has at least covered a set distance/displacement in a set amount of time, thus checking the progress of the robot. What do you think?

Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

SteveMacenski · 2020-07-20T19:13:15Z

Awesome, thanks!

* Move dwb goal/progress checker plugins to nav2_controller Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Move goal/progress checker plugins to nav2_controller Address review comments Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Move goal/progress checker plugins to nav2_controller Use new plugin declaration format and doc update Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Update bringup.yaml for new plugins in nav2_controller Also remove redundent file from dwb_plugins Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Fix doc errors and update remaining yaml files Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Remove mention of goal_checker from dwb docs Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Add .plugin params to doc Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Tests for progress_checker plugin declare .plugin only if not declared before Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Tweak plugin names/description in doc Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

* Add slam toolbox as exec dep for nav2_bringup (#1827) * Add slam toolbox as exec dep * Added slam toolbox * Changed version of slam toolbox to foxy-devel * Added modifications to allow for exec depend of slam toolbox without breaking docker / CI * reformatted skip keys * Added tabs to skip key arguments * Removed commented out code block * Add unit tests for follow path, compute path to pose, and navigate to pose BT action nodes (#1844) * Add compute path to pose unit tests Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com> * Add follow path action unit tests Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com> * Add navigate to pose action unit tests Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com> * adding foxy build icons to readme (#1853) * adding foxy build icons * adding dividers * sync master from foxy version updates (#1852) * sync master from foxy version updates * syncing foxy and master * Add unit tests for clear entire costmap and reinitialize global localization BT service nodes (#1845) * Add clear entire costmap service unit tests Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com> * Add reinitialize global localization service unit test Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com> * Temporarily disable dump_params test (#1856) Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com> * commenting out unused validPointPotential (#1854) * Adding ROS2 versions to issue template (#1861) * reload behavior tree before creating RosTopicLogger to prevent nullptr error or no /behavior_tree_log problem (#1849) Signed-off-by: Daisuke Sato <daisukes@cmu.edu> * Add citation for IROS paper (#1867) * Add citation We'll want to add the DOI once published * Bump citation section above build status * Fix line breaks * Changes RCUTILS_CONSOLE_STDOUT_LINE_BUFFERED to RCUTILS_LOGGING_BUFFERED_STREAM (#1868) * Added parameters to configure amcl laser scan topic (#1870) * Added parameters to configure amcl topic * changed parameter to scan_topic and added to all the configuration files * added scan_topic amcl param to docs * Satisfied linter * Move dwb goal/progress checker plugins to nav2_controller (#1857) * Move dwb goal/progress checker plugins to nav2_controller Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Move goal/progress checker plugins to nav2_controller Address review comments Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Move goal/progress checker plugins to nav2_controller Use new plugin declaration format and doc update Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Update bringup.yaml for new plugins in nav2_controller Also remove redundent file from dwb_plugins Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Fix doc errors and update remaining yaml files Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Remove mention of goal_checker from dwb docs Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Add .plugin params to doc Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Tests for progress_checker plugin declare .plugin only if not declared before Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Tweak plugin names/description in doc Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Follow pose (#1859) * Truncate path finished Signed-off-by: Francisco Martin Rico <fmrico@gmail.com> * Follow Pose finished Signed-off-by: Francisco Martin Rico <fmrico@gmail.com> * Change names. Add test and doc Signed-off-by: Francisco Martin Rico <fmrico@gmail.com> * Change names and check atan2 values Signed-off-by: Francisco Martin Rico <fmrico@gmail.com> * Checking Inf/NaNs and trucate path changes Signed-off-by: Francisco Martin Rico <fmrico@gmail.com> * Revert changes in launcher Signed-off-by: Francisco Martin Rico <fmrico@gmail.com> * Documenting Tree Signed-off-by: Francisco Martin Rico <fmrico@gmail.com> * Update nav2_bt_navigator/README.md Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_bt_navigator/README.md Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * Change TruncatePath from decorator to action node Signed-off-by: Francisco Martin Rico <fmrico@gmail.com> * Update nav2_bt_navigator/README.md Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * Remove Deprecated Declaration (#1884) * Remove deprecated rclcpp::executor::FutureReturnCode::SUCCESS in favor of rclcpp::FutureReturnCode::SUCCESS Signed-off-by: Hunter L. Allen <hunter.allen@ghostrobotics.io> * Update nav2_util/include/nav2_util/service_client.hpp Co-authored-by: Sarthak Mittal <sarthakmittal2608@gmail.com> Co-authored-by: Sarthak Mittal <sarthakmittal2608@gmail.com> * Added new costmap buffer to resize map safely (#1837) * Added new costmap buffer to resize map safely Signed-off-by: Aitor Miguel Blanco <aitormibl@gmail.com> * Update map if the layer is not being processed. Signed-off-by: Aitor Miguel Blanco <aitormibl@gmail.com> * Updated bool name and added buffer initialization Signed-off-by: Aitor Miguel Blanco <aitormibl@gmail.com> * Fix dump params tests (#1886) Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com> * Move definitions in tf_help to separate src cpp file (#1890) * Move definitions of functions in tf_help to separate src cpp file to avoid multiple definition error * Fix linting issues * Make uncrustify happier * More format fixing * resolved the simulated motion into its x & y components (#1887) Signed-off-by: Marwan Taher <marokhaled99@gmail.com> * Fix nav2_bt_navigator cleanup (#1901) Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com> * Adding some more test coverage (#1903) * more tests * removing old cmake * remove on_errors in specific servers in favor of a general lifecycle warning (#1904) * remove on_errors in favor of a general lifecycle warning * adding removed thing * simply nodes to remove lines (#1907) * Bunches of random new tests (#1909) * trying to get A* to work again * make flake 8 happy * adding cancel and preempt test * planner tests use A* * adding A* note * test with topic * Adding failure to navigate test (#1912) * failures tests * adding copyrights * cancel test in recoveries * Costmap lock while copying data in navfn planner (#1913) * acquire the costmap lock while copying data in navfn planner Signed-off-by: Daisuke Sato <daisukes@cmu.edu> * add costmap lock to dwb local plannger Signed-off-by: Daisuke Sato <daisukes@cmu.edu> * Added map_topic parameters to static layer and amcl (#1910) * see if spin some in cancel will allow result callback (#1914) * Adding near-complete voxel grid test coverage and more to controller server (#1915) * remove erraneous handling done by prior * adding a bunch of voxel unit tests * retrigger * adding waypoint follower failure test, voxel layer integration tests, etc (#1916) * adding waypoint follower failure test * adding voxel, more logging * reset -> clear * minor changes to lower redundent warnings (#1918) * Costmap plugins declare if not declared for reset capabilities (#1919) * fixing #1917 on declare if not declared * fix API * adding CLI test (#1920) * More coverage in map server tests (#1921) * adding CLI test * adding a bunch of new coverages for map_server * Add in range sensor costmap layer (#1888) * range costmap building * range sensor layer working * nav2 costmap pass linter and uncrustify tests * Added back semicolon to range class * Added docs * Added angles dependency * Added BSD license * Added BSD license * Made functions inline * revmoed get_clock * added input_sensor_type to docs * Made defualt topic name empty to cause error * using chorno literal to denote time units * Added small initial test * Fixed linter error, line breaks, enum, logger level, and transform_tolerance issue * fixed segmentation fault in test and added transfrom tolerances to tf_->transform * Got test to pass * Added more tests * removed incorrect parameter declaration * Improved marking while moving tests and added clearing tests * removed general clearing test * changed testing helper import in test * [Test sprint] push nav2_map_server over 90% (#1922) * adding CLI test * adding tests for more lines to map_server * fix last test * adding out of bounds and higher bounds checks * adding planner tests for plugins working * add cleanup * working * ping * [testing sprint] final test coverage and debug logging in planner/controller servers (#1924) * adding CLI test * adding tests for more lines to map_server * fix last test * adding out of bounds and higher bounds checks * adding planner tests for plugins working * add cleanup * working * ping * adding more testing and debug info messages * [testing sprint] remove dead code not used in 10 years from navfn (#1926) * remove dead code not used in 10 years from navfn * ping * inverting period to rate * removing debug statement that could never be triggered by a single non-looping action server * type change * adding removed files * bump to 0.4.2 * add another missing file * add missing files * remove some tests * lint * removing nav2_bringup from binaries Co-authored-by: Michael Equi <32988490+Michael-Equi@users.noreply.github.com> Co-authored-by: Sarthak Mittal <sarthakmittal2608@gmail.com> Co-authored-by: Daisuke Sato <43101027+daisukes@users.noreply.github.com> Co-authored-by: Ruffin <roxfoxpox@gmail.com> Co-authored-by: Siddarth Gore <siddarth.gore@gmail.com> Co-authored-by: Francisco Martín Rico <fmrico@gmail.com> Co-authored-by: Hunter L. Allen <hunter.allen@ghostrobotics.io> Co-authored-by: Aitor Miguel Blanco <aitormibl@gmail.com> Co-authored-by: Joe Smallman <ijsmallman@gmail.com> Co-authored-by: Marwan Taher <marokhaled99@gmail.com>

* Move dwb goal/progress checker plugins to nav2_controller Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Move goal/progress checker plugins to nav2_controller Address review comments Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Move goal/progress checker plugins to nav2_controller Use new plugin declaration format and doc update Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Update bringup.yaml for new plugins in nav2_controller Also remove redundent file from dwb_plugins Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Fix doc errors and update remaining yaml files Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Remove mention of goal_checker from dwb docs Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Add .plugin params to doc Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Tests for progress_checker plugin declare .plugin only if not declared before Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Tweak plugin names/description in doc Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

The plan recieved is usually in global frame, but our local costmap is often in odom frame. This fixes a regression from #1857

* waypoint_follower node has _rclcpp_node as well as base node (#1940) * Add #include <vector> for vector<> (#1946) To fix cpplint * Add 'angles' dependency to nav2_costmap_2d package.xml (#1947) * transform goal to costmap frame (#1949) The plan recieved is usually in global frame, but our local costmap is often in odom frame. This fixes a regression from #1857 * Add mutex lock into inflation layer to avoid thread issue in updating footprint (#1952) Signed-off-by: Daisuke Sato <daisukes@cmu.edu> * Fix being unable to change StandardTrajectoryGenerator parameter vtheta_samples (#1619) * Fix tests declaring parameters real nodes don't Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Fix loadParameterWithDeprecation not getting initial parameter values Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Create sim_time variable before using it Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Line length < 100 Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Add missing { Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Linter fixes Signed-off-by: Shane Loretz <sloretz@openrobotics.org> * sim_granularity -> time_granularity Signed-off-by: Shane Loretz <sloretz@openrobotics.org> * Linter fix Signed-off-by: Shane Loretz <sloretz@openrobotics.org> * update version to 0.4.3 * removing redundant dep on angles Co-authored-by: Ruffin <roxfoxpox@gmail.com> Co-authored-by: Sarthak Mittal <sarthakmittal2608@gmail.com> Co-authored-by: Michael Ferguson <mfergs7@gmail.com> Co-authored-by: Daisuke Sato <43101027+daisukes@users.noreply.github.com> Co-authored-by: Shane Loretz <sloretz@openrobotics.org>

…tion#1857) * Move dwb goal/progress checker plugins to nav2_controller Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Move goal/progress checker plugins to nav2_controller Address review comments Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Move goal/progress checker plugins to nav2_controller Use new plugin declaration format and doc update Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Update bringup.yaml for new plugins in nav2_controller Also remove redundent file from dwb_plugins Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Fix doc errors and update remaining yaml files Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Remove mention of goal_checker from dwb docs Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Add .plugin params to doc Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Tests for progress_checker plugin declare .plugin only if not declared before Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Tweak plugin names/description in doc Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

The plan recieved is usually in global frame, but our local costmap is often in odom frame. This fixes a regression from ros-navigation#1857

…tion#1857) * Move dwb goal/progress checker plugins to nav2_controller Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Move goal/progress checker plugins to nav2_controller Address review comments Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Move goal/progress checker plugins to nav2_controller Use new plugin declaration format and doc update Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Update bringup.yaml for new plugins in nav2_controller Also remove redundent file from dwb_plugins Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Fix doc errors and update remaining yaml files Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Remove mention of goal_checker from dwb docs Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Add .plugin params to doc Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Tests for progress_checker plugin declare .plugin only if not declared before Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com> * Tweak plugin names/description in doc Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

Move dwb goal/progress checker plugins to nav2_controller

d7979ee

Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

siddhya force-pushed the controller_plugin branch from 05db38d to d7979ee Compare July 7, 2020 15:37

siddhya marked this pull request as ready for review July 7, 2020 15:42

SteveMacenski requested changes Jul 7, 2020

View reviewed changes

Move goal/progress checker plugins to nav2_controller

2d466a8

Address review comments Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

SteveMacenski requested changes Jul 8, 2020

View reviewed changes

SteveMacenski mentioned this pull request Jul 8, 2020

[ROS2] API change incoming rst-tu-dortmund/teb_local_planner#215

Closed

Move goal/progress checker plugins to nav2_controller

73197ad

Use new plugin declaration format and doc update Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

SteveMacenski reviewed Jul 10, 2020

View reviewed changes

doc/parameters/param_list.md Outdated Show resolved Hide resolved

Update bringup.yaml for new plugins in nav2_controller

e271cd8

Also remove redundent file from dwb_plugins Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

siddhya mentioned this pull request Jul 13, 2020

Move goal/progress plugins from DWB to nav2_controller ros-navigation/docs.nav2.org#43

Merged

Marwan99 reviewed Jul 13, 2020

View reviewed changes

doc/parameters/param_list.md Outdated Show resolved Hide resolved

doc/parameters/param_list.md Outdated Show resolved Hide resolved

SteveMacenski reviewed Jul 13, 2020

View reviewed changes

nav2_bringup/bringup/params/nav2_params.yaml Show resolved Hide resolved

Fix doc errors and update remaining yaml files

20ef7d5

Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

SteveMacenski approved these changes Jul 14, 2020

View reviewed changes

Marwan99 reviewed Jul 14, 2020

View reviewed changes

nav2_controller/src/nav2_controller.cpp Outdated Show resolved Hide resolved

nav2_controller/src/nav2_controller.cpp Outdated Show resolved Hide resolved

siddhya added 3 commits July 15, 2020 14:43

Remove mention of goal_checker from dwb docs

6558ec8

Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

Add .plugin params to doc

2dfc4b9

Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

Tests for progress_checker plugin

9d93bae

declare .plugin only if not declared before Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

Marwan99 reviewed Jul 17, 2020

View reviewed changes

Tweak plugin names/description in doc

30740cf

Signed-off-by: Siddarth Gore <siddarth.gore@gmail.com>

Marwan99 approved these changes Jul 20, 2020

View reviewed changes

SteveMacenski merged commit d7494ec into ros-navigation:master Jul 20, 2020

siddhya deleted the controller_plugin branch July 21, 2020 04:27

mikeferguson mentioned this pull request Aug 17, 2020

transform goal to costmap frame #1949

Merged

SteveMacenski pushed a commit that referenced this pull request Aug 17, 2020

transform goal to costmap frame (#1949)

ed8ddaf

The plan recieved is usually in global frame, but our local costmap is often in odom frame. This fixes a regression from #1857

SteveMacenski pushed a commit that referenced this pull request Aug 24, 2020

transform goal to costmap frame (#1949)

5e522b8

The plan recieved is usually in global frame, but our local costmap is often in odom frame. This fixes a regression from #1857

SteveMacenski mentioned this pull request Aug 31, 2020

DWB page is not up to date after checker refactors ros-navigation/docs.nav2.org#80

Closed

ruffsl pushed a commit to ruffsl/navigation2 that referenced this pull request Jul 2, 2021

transform goal to costmap frame (ros-navigation#1949)

6e09f7a

The plan recieved is usually in global frame, but our local costmap is often in odom frame. This fixes a regression from ros-navigation#1857

Move dwb goal/progress checker plugins to nav2_controller #1857

Move dwb goal/progress checker plugins to nav2_controller #1857

Uh oh!

Conversation

siddhya commented Jul 7, 2020

Basic Info

SteveMacenski commented Jul 7, 2020

SteveMacenski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SteveMacenski commented Jul 7, 2020

codecov bot commented Jul 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

SteveMacenski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SteveMacenski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Marwan99 commented Jul 13, 2020

Uh oh!

SteveMacenski commented Jul 14, 2020

Marwan99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SteveMacenski commented Jul 16, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

siddhya Jul 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

siddhya Jul 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SteveMacenski commented Jul 20, 2020

Labels

3 participants

codecov bot commented Jul 8, 2020 •

edited

Loading

siddhya Jul 17, 2020 •

edited

Loading

siddhya Jul 20, 2020 •

edited

Loading