Skip to content

Fix uninitialized variable warnings and change default value #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2020
Merged

Fix uninitialized variable warnings and change default value #1728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
060f2cc
Fix uninitialized warning for variable temp_tf_tol.
QQting May 14, 2020
a7262d3
Change default GridBased.tolerance to 0.5 meters
QQting May 14, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nav2_bringup/bringup/params/nav2_multirobot_params_1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ planner_server:
planner_plugin_types: ["nav2_navfn_planner/NavfnPlanner"]
planner_plugin_ids: ["GridBased"]
use_sim_time: True
GridBased.tolerance: 2.0
GridBased.tolerance: 0.5
GridBased.use_astar: false
GridBased.allow_unknown: true

Expand Down
2 changes: 1 addition & 1 deletion nav2_bringup/bringup/params/nav2_multirobot_params_2.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ planner_server:
planner_plugin_types: ["nav2_navfn_planner/NavfnPlanner"]
planner_plugin_ids: ["GridBased"]
use_sim_time: True
GridBased.tolerance: 2.0
GridBased.tolerance: 0.5
GridBased.use_astar: false
GridBased.allow_unknown: true

Expand Down
2 changes: 1 addition & 1 deletion nav2_bringup/bringup/params/nav2_params.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ planner_server:
planner_plugin_types: ["nav2_navfn_planner/NavfnPlanner"]
planner_plugin_ids: ["GridBased"]
use_sim_time: True
GridBased.tolerance: 2.0
GridBased.tolerance: 0.5
GridBased.use_astar: false
GridBased.allow_unknown: true

Expand Down
2 changes: 1 addition & 1 deletion nav2_costmap_2d/plugins/static_layer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ void
StaticLayer::getParameters()
{
int temp_lethal_threshold = 0;
double temp_tf_tol;
double temp_tf_tol = 0.0;

declareParameter("enabled", rclcpp::ParameterValue(true));
declareParameter("subscribe_to_updates", rclcpp::ParameterValue(false));
Expand Down
2 changes: 1 addition & 1 deletion nav2_navfn_planner/src/navfn_planner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ NavfnPlanner::configure(

// Initialize parameters
// Declare this plugin's parameters
declare_parameter_if_not_declared(node_, name + ".tolerance", rclcpp::ParameterValue(2.0));
declare_parameter_if_not_declared(node_, name + ".tolerance", rclcpp::ParameterValue(0.5));
node_->get_parameter(name + ".tolerance", tolerance_);
declare_parameter_if_not_declared(node_, name + ".use_astar", rclcpp::ParameterValue(false));
node_->get_parameter(name + ".use_astar", use_astar_);
Expand Down