bugfix-Segmentaion fault in planner_server node. #1608 #1609
Conversation
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
You need to run the linters ament_uncrustify and ament_cpplint as you have unlinted code. Also, this needs to be retargeted to master.
| geometry_msgs::msg::PoseStamped goal_copy; | ||
| goal_copy.pose = goal; | ||
| plan.poses.push_back(goal_copy); | ||
| if (plan.poses.size() > 2){ |
There was a problem hiding this comment.
| if (plan.poses.size() > 2){ | |
| if (plan.poses.size() > 2) { |
There was a problem hiding this comment.
Corrected the changes requested. Regarding retarget to master, does that mean the eloquent- devel will not have these changes? or master will be merged later to eloquent-devel
There was a problem hiding this comment.
Also, should I create a new pull request for the master branch with cherrypicked commits from the current pull request?
There was a problem hiding this comment.
Master may be eventually synced with eloquent, but all new development goes to master. You may create a new PR or rebase.
There was a problem hiding this comment.
#1612 have raised the new PR, we can close this PR
…replace last pose of computed path
Codecov Report
@@ Coverage Diff @@
## eloquent-devel #1609 +/- ##
=================================================
Coverage ? 36.14%
=================================================
Files ? 233
Lines ? 12089
Branches ? 5251
=================================================
Hits ? 4369
Misses ? 4502
Partials ? 3218
Continue to review full report at Codecov.
|
2 participants
Basic Info