Skip to content

Upgrade to SDL2.0.20 #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 12, 2023
Merged

Upgrade to SDL2.0.20 #270

merged 3 commits into from
Oct 12, 2023

Conversation

@roncapat
Copy link
Contributor

@roncapat roncapat commented Oct 5, 2023

Fix #267
@roncapat
Upgrade to SDL2.0.18
31150ab 
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
clalancette
clalancette requested changes Oct 10, 2023
View reviewed changes
@roncapat roncapat changed the title Upgrade to SDL2.0.18 Oct 10, 2023
@roncapat roncapat requested a review from clalancette October 11, 2023 07:39
@roncapat
Copy link
Contributor Author

roncapat commented Oct 12, 2023 •
edited
Loading

@clalancette I noticed a problem with the sdl2_vendor/sdl2-windows-add-vcruntime.patch patch not being applied after switching to point release 20. I'll do some checks and report.
@roncapat
Copy link
Contributor Author

roncapat commented Oct 12, 2023

Should be fixed now. I warn you that it seems to me that during CI the SDL doesn't get built from sources (it may already be present in Ubuntu packages). Maybe FORCE_BUILD_VENDOR_PKG is not set?
@clalancette
Copy link
Contributor

clalancette commented Oct 12, 2023

Maybe FORCE_BUILD_VENDOR_PKG is not set?

Yeah, it is not: https://github.com/ros-drivers/joystick_drivers/blob/ros2/.github/workflows/rolling-build-ci.yaml

The vendoring of this package was mostly meant for Windows; on Linux, we generally have a packaged SDL available (though I guess in this case, it might be too old). One thing we could consider would be to build it if the SDL version is not new enough to have the game controller interface.
clalancette
clalancette approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the update.
@clalancette clalancette merged commit f2ffeec into ros-drivers:ros2 Oct 12, 2023
@meyerj meyerj mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@roncapat @clalancette