Support Go Modules #211
Closed
Support Go Modules #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Please see #169 (comment) and the linked issues for more infos. |
Contributor
Author
|
The release branch has been cut and a beta is out; this will not change before 1.12. Not to mention that it has been merged and released into all supported Go versions. Now is the time we're trying to get adoption up before it becomes the default in 1.12. This has been announced, it is final, it is official. Please reconsider so that we can have our packages that depend on tview ready before the final release of 1.12 is cut. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Please consider supporting Go Modules, the new packaging standard that will be adopted fully in Go 1.12. Experimental support is in Go 1.11 and the new module paths are supported in Go 1.9.7+ and Go 1.10.3+ in a read-only manner for backwards compatibility with all supported versions of Go.
Because this library is still below version 2 the
go.modfile is fairly simple. The only other thing that would need to be done if this PR were merged is to create a semver compatible tag (eg.v0.0.1) that users of this library can pin to.Thank you for your consideration.