feat: Add design overlay functionality #1460
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create design-overlay slice with setDesignOverlay and removeDesignOverlay actions - Add designOverlays schema to electron store for persistence - Integrate designOverlay reducer into main Redux store - Load persisted overlays on app initialization
- Add scrollX and scrollY to pass-scroll-data IPC messages - Update Coordinates interface to include scrollX and scrollY - Update Device component to handle new scroll coordinates
- Introduce DesignOverlayControls component for managing design overlays - Implement state management for overlay settings including image upload, opacity, and position - Add DesignOverlay component to render the overlay based on user settings - Integrate new controls into the Toolbar for user interaction
- Rearrange imports for better organization in Device component - Update resolution handling to use a consistent format - Enhance design overlay rendering logic based on state - Fix scroll data handling to correctly reference scroll coordinates - Add optional fileName property to DesignOverlayState for future use
…lity - Add optional showFileName and initialFileName props to FileUploader - Implement state management for displaying the selected file name - Update file input handling to reset value based on showFileName prop - Refactor component structure to conditionally render file name and upload button
- Implement tests for setDesignOverlay and removeDesignOverlay actions - Validate state updates and persistence to electron store - Add selectors to retrieve overlay state and enabled status - Ensure coverage for various scenarios including existing and non-existent overlays
|
|
- Bump ResponsivelyApp version to 1.17.1 in package-lock.json and yarn.lock - Adjust scroll position calculations in DesignOverlay to account for zoom factor
Author
|
Core Features: +1
divider.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Pull Request
ℹ️ About the PR
This PR introduces a comprehensive design overlay feature that allows users to overlay design images on device previews for visual comparison. The implementation includes:
Core Features:
🖼️ Testing Scenarios / Screenshots
Testing Performed:
Manual Testing Scenarios:
Screenshots: