Skip to content

Conversation

@meezumi
Copy link
Contributor

@meezumi meezumi commented Sep 26, 2025

✨ Pull Request

📓 Referenced Issue

Referenced to the issue #677

  • replaced the globe icon with a clickable icon/button
  • added site permissions drop-down, matching the theme of the application

ℹ️ About the PR

New Files Created

SitePermissionsDropdown Component

File: desktop-app/src/renderer/components/ToolBar/AddressBar/SitePermissions/index.tsx

Features:

  • Interactive Globe Icon: Dropdown interface matching application theme
  • 8 Permission Types: Camera, Microphone, Location, Notifications, Clipboard, Fullscreen, MIDI, Pointer Lock
  • 3-State Management: Ask (default) → Allow → Block → Ask (cyclical toggle)

Modified Files

AddressBar Component Updates

File: desktop-app/src/renderer/components/ToolBar/AddressBar/index.tsx

Changes:

  • Made globe icon clickable with proper hover effects (rounded-full)
  • Added showSitePermissions state management
  • Integrated dropdown positioning and visibility controls
  • Added circular hover animation matching other address bar icons

Backend Permission System Enhancements

Files Modified:

  • desktop-app/src/main/web-permissions/PermissionsManager.ts
  • desktop-app/src/main/web-permissions/index.ts
  • desktop-app/src/common/constants.ts
  • desktop-app/src/main/preload-webview.ts

🖼️ Testing Scenarios / Screenshots

  • Permission dialog ↔ flyout sync
  • Page refresh notifications and reload
  • Permission reset functionality
  • Session cache clearing
  • Click-outside dropdown behavior

Images

Screenshot From 2025-09-26 18-32-44
- replaced the globe icon with a clickable icon/button
- added site permissions dropdown, matching the theme of the application
- Fixes responsively-org#677
@CLAassistant
Copy link

CLAassistant commented Sep 26, 2025

CLA assistant check
All committers have signed the CLA.

@manojVivek manojVivek merged commit 7b5f03f into responsively-org:main Oct 11, 2025
4 checks passed
@manojVivek
Copy link
Collaborator

@all-contributors Please add @meezumi for code.

@allcontributors
Copy link
Contributor

@manojVivek

I've put up a pull request to add @meezumi! 🎉

Copy link
Collaborator

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants