Fix/url naviagtion not working #1396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents race condition between AddressBar and webview navigation events that was causing URLs to revert back to previous values.
… of updating webview directly causing react to get out of sync and crash
|
|
manojVivek
approved these changes
Jul 26, 2025
Collaborator
manojVivek
left a comment
manojVivek
left a comment
There was a problem hiding this comment.
Thank you for fixing this painstaking bug!
Collaborator
|
@all-contributors Please add @Kieren-Foenander for code. |
Contributor
|
I've put up a pull request to add @Kieren-Foenander! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Pull Request
📓 Referenced Issue
Resolves: #1395
ℹ️ About the PR
fixes a race condition between addressBar navigation and didNavigateHandler overwriting the Redux store. Ensures addressbar navigation is dispatched properly and then cleaned up to allow for normal navigation.
🖼️ Testing Scenarios / Screenshots