Fixes issue #1111: Screenshot location input remains white in dark mode In Settings Dialog #1112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…white in dark mode In Settings Dialog
|
|
manojVivek
approved these changes
Oct 6, 2023
Collaborator
manojVivek
left a comment
manojVivek
left a comment
There was a problem hiding this comment.
Looks great, thanks for your contribution. Looking forward to more like this! 🎉
Collaborator
|
@all-contributors Please add @NishidhJain for code. |
Contributor
|
I've put up a pull request to add @NishidhJain! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Pull Request
📓 Referenced Issue
Resolves <#1111 >
ℹ️ About the PR
I have added tailwind class to change the input background in dark mode. I have also added max-width to settings dialog so it does not grow too long on larger screens.
🖼️ Testing Scenarios / Screenshots
Dark Mode
Light Mode
Tested for both light & dark mode