Handle the missing DCP state in pico_float_pico_dcp #2794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes raspberrypi#2793 Signed-off-by: Andy Lin <andylinpersonal@gmail.com>
andylinpersonal
force-pushed
the
dev/fix-unsaved-dcp-in-pico-float
branch
from
33d6aa2 to
f320b40
Compare
lurch
reviewed
Jan 12, 2026
| 2: | ||
| movs r0, #0 | ||
| bx lr | ||
| saving_func_return |
Contributor
There was a problem hiding this comment.
I know absolutely nothing about what this code is doing, but should float2fix also be updated to use saving_func_return instead of bx lr ?
Author
There was a problem hiding this comment.
Just keep consistent with elsewhere. Indeed saving_func_return is also bx lr 😌.
pico-sdk/src/rp2_common/pico_float/float_aeabi_dcp.S
Lines 59 to 61 in 9c6713a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2793