Skip to content

Fix RP2040 crash with PICO_*_IN_RAM and NaN propagation #2772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
andylinpersonal wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix RP2040 crash with PICO_*_IN_RAM and NaN propagation #2772

andylinpersonal wants to merge 1 commit into from

Conversation

@andylinpersonal
Copy link

@andylinpersonal andylinpersonal commented Dec 27, 2025 •
edited
Loading

__check_nan<f|d><1|2> is hard-coded into .text instead of being wrapped with <double|float>_section like other __aeabi* functions. When those functions are moved to SRAM, this leaves __check_nan* in flash, causing GCC to emit a veneer call that clobbers ip and corrupts the saved lr in wrapper_func_<d|f><1|2>.

Fixes #2771
@andylinpersonal
Fix RP2040 crash with PICO_*_IN_RAM and NaN propagation
cd1300f 
  ``__check_nan<f|d><1|2>`` is hard-coded into ``.text`` instead
of being wrapped with ``<double|float>_section`` like other
``__aeabi*`` functions. When those functions are moved to SRAM,
this leaves ``__check_nan*`` in flash, causing GCC to emit a veneer
call that clobbers ip and corrupts the saved ``lr`` in
``wrapper_func_<d|f><1|2>``.

Fixes raspberrypi#2771

Signed-off-by: Andy Lin <andylinpersonal@gmail.com>
@andylinpersonal andylinpersonal force-pushed the dev/fix-break-checknan-for-fp-in-ram branch from d51c6ea to cd1300f Compare December 27, 2025 20:40
@kilograham kilograham self-assigned this Dec 29, 2025
@kilograham kilograham added this to the 2.2.1 milestone Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

floating point

3 participants

@andylinpersonal @lurch @kilograham