remove guards that disable sdio_usb when tinyusb_host is linked in #2764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t works just fine
Contributor
|
Doesn't this have to be a bit more intelligent? In case someone thinks they can do this without Pico-PIO-USB? |
Author
Excellent points -- I will add better guards (basically if host and NOT pico-pio-usb using host on PIO-USB) and also include an example that I've personally tested. |
Author
|
Ok, I've created a pull request in the Pico-PIO-USB project to provide the example: sekigon-gonnoc/Pico-PIO-USB#195 |
Author
|
bump -- is there anything preventing this PR from getting merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2763.
I have a working demonstration with tinyusb_host and tinyusb_device linked in along with Pico-PIO-USB; everything is working fine (including picoloader reset).
I started off copying and pasting the sdio_usb.c code and implementing my own sdio interface, and once that worked I started looking at how to get things working with the sdk's implementation.