Misc cleanup #2569
Merged
Misc cleanup #2569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cleanup some #ifdefs which were slightly hacky when RP2350 was added; use HAS_ flags in preference to PICO_RP2040/RP2350 * make some dependencies more explicit - i.e. compile if the user doesn't want to include certain libraries * cleanup some directory A -> directory B relative path names in CMakeLists.txt to be SDK root -> directory B
will-v-pi
reviewed
Jul 17, 2025
will-v-pi
reviewed
Jul 17, 2025
will-v-pi
reviewed
Jul 17, 2025
lurch
reviewed
Jul 17, 2025
lurch
reviewed
Jul 17, 2025
lurch
reviewed
Jul 17, 2025
lurch
reviewed
Jul 17, 2025
Co-authored-by: will-v-pi <108662275+will-v-pi@users.noreply.github.com>
Co-authored-by: will-v-pi <108662275+will-v-pi@users.noreply.github.com>
Co-authored-by: will-v-pi <108662275+will-v-pi@users.noreply.github.com>
Co-authored-by: will-v-pi <108662275+will-v-pi@users.noreply.github.com>
Co-authored-by: Andrew Scheller <andrew.scheller@raspberrypi.com>
Co-authored-by: Andrew Scheller <andrew.scheller@raspberrypi.com>
lurch
reviewed
Jul 17, 2025
lurch
reviewed
Jul 17, 2025
Contributor
lurch
left a comment
lurch
left a comment
There was a problem hiding this comment.
I don't know what all of these changes are actually doing, but they all seem broadly sensible 👍
will-v-pi
previously approved these changes
Jul 17, 2025
Contributor
will-v-pi
left a comment
will-v-pi
left a comment
There was a problem hiding this comment.
LGTM - with that extra indentation fix that I missed
Co-authored-by: Andrew Scheller <andrew.scheller@raspberrypi.com>
lurch
approved these changes
Jul 17, 2025
will-v-pi
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.