QVM - deprecate default gate_times_ns in noise_properties_from_calibration #7399
Conversation
…d virtual processors Add tests for all known virtual processors.
…tum_virtual_machine
…times_ns Show deprecation warning when `gate_times_ns` argument is not provided. Introduce literal "sycamore" value as an alias for legacy defaults.
Replace use of noise_properties_from_calibration for more convenience with gate_times_ns argument.
pavoljuhas
requested review from
vtomole,
a team,
wcourtney and
verult
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7399 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 1112 1112
Lines 97709 97737 +28
=======================================
+ Hits 96427 96455 +28
Misses 1282 1282 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| gate_times_ns: Map of gate durations in nanoseconds or "sycamore" | ||
| to use the Sycamore gate times listed in `known_devices.py`. | ||
| Note this argument has changed from optional to mandatory. | ||
| Use "sycamore" to get the legacy default values. |
There was a problem hiding this comment.
Calling the old defaults "Sycamore" values might give the false impression that gates on Sycamore devices always used these durations. For example, in the M2 paper, the CZ gate was 34 ns, not 32 ns, and readout was 500 ns, not 4000 ns, even though that was a Sycamore processor (see M2 SM, Sec I.D, I.E). Maybe we can call them old defaults or something. We can also have a name for the durations in the new QVM.
There was a problem hiding this comment.
Good point - done in 0e7c505. Renamed to "legacy".
Update notebooks in next PR. They need a dev release on PyPI first. This reverts commit ff2f7d1.
Should be less confusing than "sycamore".
pavoljuhas
added
the
BREAKING CHANGE
noise_properties_from_calibration- show deprecation warning whencalled without
gate_times_nsand introduce literal "legacy" asan alias for the old gate times default.
load_device_noise_properties- update to use legacy gate times forold virtual processors and make tests more comprehensive.
Related to b/395705720