Skip to content

Fixes #7072: Support more OpenQASM 2.0 gates from qelib1.inc #7377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ACE07-Sev
Copy link

@ACE07-Sev ACE07-Sev commented May 28, 2025

Added:

  • u0
  • u
  • p
  • csx (via ops.ControlledGate)
  • cu2 (via ops.ControlledGate)
  • cu (via ops.ControlledGate)
  • c3x (via ops.ControlledGate)
  • c4x (via ops.ControlledGate)

Added some preliminary testers for maintainer review and feedback.

@ACE07-Sev ACE07-Sev requested review from vtomole and a team as code owners May 28, 2025 13:16
@ACE07-Sev ACE07-Sev requested a review from viathor May 28, 2025 13:16
Copy link

google-cla bot commented May 28, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the size: M 50< lines changed <250 label May 28, 2025
@ACE07-Sev
Copy link
Author

I see the format issue, but why did Ubuntu fail?

@pavoljuhas
Copy link
Collaborator

@ACE07-Sev - please complete the CLA, we are not able to accept PRs without it.

@ACE07-Sev
Copy link
Author

ACE07-Sev commented May 28, 2025

Done sir.

@mhucka mhucka changed the title - Fixes #7072 May 28, 2025
@ACE07-Sev
Copy link
Author

It still fails with Ubuntu it seems.

@ACE07-Sev
Copy link
Author

Found the issues. Pushing in a moment.

- Fixed `_parser.py` formatting issues.
@ACE07-Sev
Copy link
Author

Some gates from the ones that I added and the ones the last person added (crx, cry) were missing in tester params. It should be okay now.

I'm surprised why Windows and MacOs passed.

@ACE07-Sev
Copy link
Author

@mhucka Apologies for the bother. Could you kindly run the actions please?

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (c000fae) to head (8f81a93).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7377   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files        1112     1112           
  Lines       97641    97678   +37     
=======================================
+ Hits        96354    96396   +42     
+ Misses       1287     1282    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@daxfohl
Copy link
Collaborator

daxfohl commented May 28, 2025

@ACE07-Sev fyi you can run check/format-incremental --apply from command line. I usually run that, check/pytest-changed-files, check/mypy, check/pylint-changed-files, then finally check/pytest before submitting.

@ACE07-Sev
Copy link
Author

@daxfohl I tried that, but it opens the code file for the formatter instead of formatting the .py. Maybe I'm doing sth wrong. The difference is small, I can quickly fix from the traceback and push for now.

@ACE07-Sev
Copy link
Author

ACE07-Sev commented May 29, 2025

I see it. Fixing now...

I do apologize for the inconvenience by the way. I usually run these locally, but couldn't set them up properly.

@ACE07-Sev
Copy link
Author

Test pwease?

@ACE07-Sev
Copy link
Author

Is it being sarcastic by "short test summary" for the one that failed? That's so long hehe.

@ACE07-Sev
Copy link
Author

The one that failed seems to be from cirq-web. I don't think that's sth I broke, maybe it's from what you were discussing yesterday during the biweekly session?

@ACE07-Sev
Copy link
Author

I'd appreciate some feedback on the PR and guidance for the error. Thank you.

@ACE07-Sev
Copy link
Author

I see the checks pass now. LGTY?

@ACE07-Sev
Copy link
Author

Greetings there,

May I ask if there are any other items I need to add/modify for the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qasm size: M 50< lines changed <250
4 participants