-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fixes #7072: Support more OpenQASM 2.0 gates from qelib1.inc #7377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
I see the format issue, but why did Ubuntu fail? |
@ACE07-Sev - please complete the CLA, we are not able to accept PRs without it. |
Done sir. |
It still fails with Ubuntu it seems. |
Found the issues. Pushing in a moment. |
- Fixed `_parser.py` formatting issues.
Some gates from the ones that I added and the ones the last person added (crx, cry) were missing in tester params. It should be okay now. I'm surprised why Windows and MacOs passed. |
@mhucka Apologies for the bother. Could you kindly run the actions please? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7377 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 1112 1112
Lines 97641 97678 +37
=======================================
+ Hits 96354 96396 +42
+ Misses 1287 1282 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@ACE07-Sev fyi you can run |
@daxfohl I tried that, but it opens the code file for the formatter instead of formatting the .py. Maybe I'm doing sth wrong. The difference is small, I can quickly fix from the traceback and push for now. |
I see it. Fixing now... I do apologize for the inconvenience by the way. I usually run these locally, but couldn't set them up properly. |
Test pwease? |
Is it being sarcastic by "short test summary" for the one that failed? That's so long hehe. |
The one that failed seems to be from cirq-web. I don't think that's sth I broke, maybe it's from what you were discussing yesterday during the biweekly session? |
I'd appreciate some feedback on the PR and guidance for the error. Thank you. |
I see the checks pass now. LGTY? |
Greetings there, May I ask if there are any other items I need to add/modify for the PR? |
Added:
Added some preliminary testers for maintainer review and feedback.