-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add parameter sweep support for Pauli string measurements with readout mitigation #7358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7358 +/- ##
========================================
Coverage 98.68% 98.68%
========================================
Files 1112 1112
Lines 97588 97776 +188
========================================
+ Hits 96307 96495 +188
Misses 1281 1281 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ngs to be all 1000 to avoid test flakiness
Hey @eliottrosenberg and @NoureldinYosri, can you take a look when you have time? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ddddddanni! I tried testing this through Quantum Engine, and I got the error ValueError: Unsupported type for serializing const sweep: value=1 and type(value)=<class 'numpy.int64'>
. See this colab for details.
this issue is not related to this PR .. #7398 will fix it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @ddddddanni! Thank you!!
Tested in this colab.
#7236 and #7067 builds a tool for measuring expectation values of Pauli strings with readout error mitigation. This pr enhances the tool by providing option for sweep-based execution. The new sweep mode could make it faster for external users since for them sweep operations can be more efficient than run_batch with large circuit lists.
The changes include:
run_sweep_with_readout_benchmarking
which runs the sweep circuits with readout error benchmarking (without shuffling).