Skip to content

fix tests #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2018
Merged

fix tests #34

merged 2 commits into from
Oct 30, 2018

Conversation

podtserkovskiy
Copy link
Member

No description provided.

Mikhail Podtserkovskiy added 2 commits October 30, 2018 11:39
@codecov-io
Copy link

Codecov Report

Merging #34 into master will increase coverage by 0.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #34      +/-   ##
=========================================
+ Coverage   63.69%   64.4%   +0.71%     
=========================================
  Files          19      21       +2     
  Lines         606     871     +265     
=========================================
+ Hits          386     561     +175     
- Misses        206     267      +61     
- Partials       14      43      +29
Impacted Files Coverage Δ
storage/mysql/storage.go 66.66% <0%> (ø)
storage/mysql/factory.go 0% <0%> (ø)
pool/pool.go 85.22% <0%> (+4.54%) ⬆️
pool/strategy/persistent/strategy.go 79.24% <0%> (+5.66%) ⬆️
pool/capabilities/comparator.go 100% <0%> (+7.14%) ⬆️
pool/strategy/persistent/nodeHelper.go 100% <0%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2f8bac...3b218e7. Read the comment docs.

@podtserkovskiy podtserkovskiy merged commit d06473a into master Oct 30, 2018
@podtserkovskiy podtserkovskiy deleted the fix_tests branch October 30, 2018 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants