Repository navigation
[PJRT] Use PJRT by default if XRT is not configured - #4599
Merged
Merged
Conversation
JackCaoG
reviewed
Feb 9, 2023
|
|
||
| XRT_RUN_SERVER_PROCESS = 'torch_xla.core._xrt_run_server' | ||
| XRT_SERVER_REGEX = '^python3 -m {} [0-9]+$'.format(XRT_RUN_SERVER_PROCESS) | ||
| XRT_CONFIG_ENV_VARS = ['XRT_TPU_CONFIG', 'XRT_DEVICE_MAP', 'XRT_WORKERS'] |
Collaborator
There was a problem hiding this comment.
currently if user sets GPU_NUM_DEVICES it will default to xrt:gpu, user have to overwrite that with additional PJRT_DEVICE=GPU. I guess we intentionally don't change that behavior there?
Collaborator
Author
There was a problem hiding this comment.
Right. I left GPU out intentionally because we don't have the same easy way of knowing that the user intended XRT, and there are still some feature gaps on PJRT GPU.
JackCaoG
approved these changes
Feb 9, 2023
2 tasks done
chandrasekhard2
pushed a commit
that referenced
this pull request
Feb 22, 2023
* Use PJRT runtime by default * formatting * Don't set the runtime when `GPU_NUM_DEVICES` is present
chandrasekhard2
pushed a commit
that referenced
this pull request
Feb 22, 2023
* Use PJRT runtime by default * formatting * Don't set the runtime when `GPU_NUM_DEVICES` is present
mateuszlewko
pushed a commit
that referenced
this pull request
Mar 15, 2023
* Use PJRT runtime by default * formatting * Don't set the runtime when `GPU_NUM_DEVICES` is present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you don't set XRT configuration today, we print a warning that there is no XLA configuration. Instead, let's set the default device to PJRT:CPU or PJRT:TPU, depending on what is available.
Existing workloads that already set up XRT configuration will be unaffected by this change. However, we'll still print a warning for now to let the user know that they're using PJRT instead of XRT.
Example output: