Skip to content

[LTC] Metrics can be reset too - #89606

Closed
alanwaketan wants to merge 5 commits into
masterfrom
alanwaketan/metrics2
Closed

[LTC] Metrics can be reset too#89606
alanwaketan wants to merge 5 commits into
masterfrom
alanwaketan/metrics2

Conversation

@alanwaketan

@alanwaketan alanwaketan commented Nov 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary:
This change allow MetricsArena to ResetMetrics too. And then rename Reset to ResetCounters given that's what it does for real.

This matches pytorch/xla#4109, and is paired with pytorch/xla#4245.

Test Plan:
CI.
@alanwaketan alanwaketan self-assigned this Nov 23, 2022
@pytorch-bot

pytorch-bot Bot commented Nov 23, 2022 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89606

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3c78ef1:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.
@alanwaketan alanwaketan mentioned this pull request Nov 24, 2022
Merged
@alanwaketan
alanwaketan requested a review from JackCaoG November 24, 2022 01:44
@alanwaketan
alanwaketan requested a review from a team as a code owner November 24, 2022 01:45
JackCaoG
JackCaoG approved these changes Nov 24, 2022
View reviewed changes

@JackCaoG JackCaoG left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need metrics outside of computation client? I guess we need it eventually.
@alanwaketan

alanwaketan commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator Author

Do we need metrics outside of computation client? I guess we need it eventually.

We actually use that in a lot of places. See pytorch/xla#4245.
@alanwaketan

alanwaketan commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge -g
@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 24, 2022
@pytorchmergebot

pytorchmergebot commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here
@pytorchmergebot

pytorchmergebot commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule Lazy Tensor):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job
@alanwaketan

alanwaketan commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge -g
@pytorchmergebot

pytorchmergebot commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here
@pytorchmergebot

pytorchmergebot commented Nov 24, 2022

Copy link
Copy Markdown
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule Lazy Tensor):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job
@alanwaketan
[LTC] Metrics can be reset too
85f3d95 
Summary:
This change allow MetricsArena to ResetMetrics too. And then rename
Reset to ResetCounters given that's what it does for real.

This matches pytorch/xla#4109.

Test Plan:
CI.
@alanwaketan
Refine resets
509e82f
@alanwaketan
fix litners
ec4715a
@alanwaketan
Update XLA hash
9ee1bf3
@alanwaketan
Fix linters
3c78ef1
@alanwaketan

alanwaketan commented Nov 28, 2022

Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge -g
@pytorchmergebot

pytorchmergebot commented Nov 28, 2022

Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@alanwaketan @kulinseth
[LTC] Metrics can be reset too (pytorch#89606)
66d6ece 
Summary:
This change allow MetricsArena to ResetMetrics too. And then rename Reset to ResetCounters given that's what it does for real.

This matches pytorch/xla#4109, and is paired with pytorch/xla#4245.

Test Plan:
CI.

Pull Request resolved: pytorch#89606
Approved by: https://github.com/JackCaoG
@github-actions
github-actions Bot deleted the alanwaketan/metrics2 branch May 30, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

3 participants

@alanwaketan @pytorchmergebot @JackCaoG