Fix warnings revealed by v0.14.1 PS release; export functions#139
Merged
JordanMartinez merged 4 commits intopurescript:masterfrom Apr 25, 2021
JordanMartinez:fixWarnings
Merged
Fix warnings revealed by v0.14.1 PS release; export functions#139JordanMartinez merged 4 commits intopurescript:masterfrom JordanMartinez:fixWarnings
JordanMartinez merged 4 commits intopurescript:masterfrom
JordanMartinez:fixWarnings
Conversation
Exported functions - mapCont - withCont
hdgarrood
reviewed
Apr 25, 2021
CHANGELOG.md
Outdated
| Breaking changes: | ||
|
|
||
| New features: | ||
| - Export `mapCont` and `withCont` functions (#139 by @JordanMartinez) |
Contributor
There was a problem hiding this comment.
If these were introduced in a separate PR and originally meant to be exported, we should probably link to the PR that actually introduced them I think.
Contributor
Author
There was a problem hiding this comment.
Looks like the functions were originally added in #70
Contributor
Author
There was a problem hiding this comment.
I've added the PR to the changelog entry. Does that suffice?
hdgarrood
reviewed
Apr 25, 2021
CHANGELOG.md
Outdated
| Breaking changes: | ||
|
|
||
| New features: | ||
| - Export `mapCont` and `withCont` functions originally added in #70 by @parsonmatt (#139 by @JordanMartinez) |
Contributor
There was a problem hiding this comment.
Suggested change
| - Export `mapCont` and `withCont` functions originally added in #70 by @parsonmatt (#139 by @JordanMartinez) | |
| - Export `mapCont` and `withCont` functions originally added in #70 by @parsonsmatt (#139 by @JordanMartinez) |
hdgarrood
approved these changes
Apr 25, 2021
Contributor
hdgarrood
left a comment
hdgarrood
left a comment
There was a problem hiding this comment.
Looks good! (apart from the typo)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Self-explanatory. Backlinking to purescript/purescript#4071
Checklist: